Bug 1163476

Summary:	gwenview FTBFS against latest libjpeg-turbo
Product:	[Fedora] Fedora	Reporter:	Rex Dieter <rdieter>
Component:	gwenview	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	alekcejk, kevin, ltinkl, rdieter, rnovacek, than
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-17 14:58:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1164815
Bug Blocks:

Description Rex Dieter 2014-11-12 19:05:45 UTC

gwenview FTBFS against latest libjpeg-turbo, see
https://koji.fedoraproject.org/koji/taskinfo?taskID=8074343

Excerpt:

In file included from ../../lib/cms/iccjpeg.c:42:0:
../../lib/cms/iccjpeg.h:55:31: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'JPP'
 extern void write_icc_profile JPP((j_compress_ptr cinfo,
                               ^
../../lib/cms/iccjpeg.h:76:36: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'JPP'
 extern void setup_read_icc_profile JPP((j_decompress_ptr cinfo));
                                    ^
../../lib/cms/iccjpeg.h:95:33: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'JPP'
 extern boolean read_icc_profile JPP((j_decompress_ptr cinfo,
                                 ^
../../lib/cms/iccjpeg.c: In function 'read_icc_profile':
../../lib/cms/iccjpeg.c:253:18: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
       JOCTET FAR *src_ptr;
                  ^
../../lib/cms/iccjpeg.c:253:19: error: 'src_ptr' undeclared (first use in this function)
       JOCTET FAR *src_ptr;
                   ^
../../lib/cms/iccjpeg.c:253:19: note: each undeclared identifier is reported only once for each function it appears in
lib/CMakeFiles/gwenviewlib.dir/build.make:113: recipe for target 'lib/CMakeFiles/gwenviewlib.dir/cms/iccjpeg.o' failed

Comment 1 nucleo 2014-11-14 06:05:53 UTC

Similar problems in digikam https://bugs.kde.org/show_bug.cgi?id=340944
Maybe this is libjpeg-turbo bug?

Comment 2 Kevin Kofler 2014-11-14 16:05:57 UTC

The JPP macro was removed. That's a macro that enabled or disabled modern-day C prototypes. They probably figured that people long stopped caring about ancient pre-standard K&R C. The easiest workaround is to just remove the JPP(…) wrappers, or to:
#ifndef JPP
#define JPP(x) x
#endif

That said, seeing how many packages are affected, IMHO, this backwards-incompatible change in libjpeg-turbo should be reverted.

Comment 3 Rex Dieter 2014-11-17 14:58:41 UTC

I found this upstream ml thread,
http://sourceforge.net/p/libjpeg-turbo/mailman/message/32677570/

I included a workaround patch in the meantime:

%changelog
* Mon Nov 17 2014 Rex Dieter <rdieter> - 4.14.3-2
- fix/workaround FTBFS against new libjpeg-turbo (#1163476)
- use %%find_lang