Bug 116355

Summary: 4 * printf problems
Product: [Fedora] Fedora Reporter: d.binderman
Component: eximAssignee: Thomas Woerner <twoerner>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-07-02 14:23:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description d.binderman 2004-02-20 14:35:01 UTC
Description of problem:

I just tried to compile development package exim-4.30-5

The compiler said

1.

pipe.c(835): warning #268: the format string ends before this argument

The source code is

    addr->message = string_sprintf("pipe delivery process timed out",
      tblock->name);

Suggest add % specifier for tblock->name

2.

smtp.c(1497): warning #268: the format string ends before this argument

The source code is

  message = US string_sprintf("send() to %s [%s] failed",
    host->name, host->address, strerror(save_errno));

Two % specifiers, three parameters.

3.

smtp.c(1644): warning #268: the format string ends before this argument

The source code is

        msg = US string_sprintf("send() to %s [%s] failed", host->name,
          host->address, strerror(save_errno));

Similar fun & games.

4.

smtp_out.c(110): warning #267: the format string requires additional
arguments

The source code is

  addr->message = string_sprintf("failed to expand \"%s\" (\"port\"
option) "
    "for %s: %s", msg, expand_string_message);

Three % specifiers, two parameters.

Suggest use compiler flag -Wformat to prevent these problems happening
in future.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Thomas Woerner 2004-07-02 12:56:02 UTC
*** Bug 118175 has been marked as a duplicate of this bug. ***

Comment 2 Thomas Woerner 2004-07-02 14:23:44 UTC
Fixed in rawhide in package exim-4.34-3 or newer.