Bug 1163814

Available new releases, please consider upgrading
https://github.com/SonarSource/sonarqube/releases/tag/5.0-M16
https://github.com/SonarSource/sonarqube/releases/tag/4.5.1

(In reply to gil cattaneo from comment #1)
> Available new releases, please consider upgrading
> https://github.com/SonarSource/sonarqube/releases/tag/5.0-M16
> https://github.com/SonarSource/sonarqube/releases/tag/4.5.1

I'm aware of that, but we need sonar mainly as a dependency of gradle, which doesn't work with newer versions.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
    Please install COPYING copyright.txt files
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "MIT/X11 (BSD like)", "LGPL (v3 or later)", "GPL (v2 or
     later)", "Unknown or generated". 1051 files have unknown license.
     Detailed output of licensecheck in
     /home/gil/1163814-sonar/licensecheck.txt
    Please, change license tag in LGPLv3
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/maven-metadata, /usr/share/maven-
     poms/sonar
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/maven-poms/sonar,
     /usr/share/maven-metadata
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: sonar-3.2-1.fc22.noarch.rpm
          sonar-3.2-1.fc22.src.rpm
sonar.noarch: W: no-documentation
sonar.src: E: specfile-error pom_remove_plugin: invalid option -- 'r'
sonar.src: E: specfile-error error: Unknown option r in pom_remove_plugin()
sonar.src: E: specfile-error pom_remove_plugin: invalid option -- 'r'
sonar.src: E: specfile-error error: Unknown option r in pom_remove_plugin()
sonar.src: E: specfile-error pom_remove_plugin: invalid option -- 'r'
sonar.src: E: specfile-error error: Unknown option r in pom_remove_plugin()
2 packages and 0 specfiles checked; 6 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint sonar
sonar.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
# echo 'rpmlint-done:'



Requires
--------
sonar (rpmlib, GLIBC filtered):
    java-headless
    jpackage-utils
    mvn(ch.qos.logback:logback-classic)
    mvn(ch.qos.logback:logback-core)
    mvn(com.fasterxml.staxmate:staxmate)
    mvn(com.google.guava:guava)
    mvn(com.googlecode.json-simple:json-simple)
    mvn(com.puppycrawl.tools:checkstyle)
    mvn(com.thoughtworks.xstream:xstream)
    mvn(commons-codec:commons-codec)
    mvn(commons-configuration:commons-configuration)
    mvn(commons-dbcp:commons-dbcp)
    mvn(commons-io:commons-io)
    mvn(commons-lang:commons-lang)
    mvn(javax.persistence:persistence-api)
    mvn(javax.servlet:servlet-api)
    mvn(org.apache.commons:commons-email)
    mvn(org.apache.geronimo.specs:geronimo-jta_1.1_spec)
    mvn(org.apache.maven.shared:maven-dependency-tree)
    mvn(org.apache.maven:maven-artifact)
    mvn(org.apache.maven:maven-core)
    mvn(org.apache.maven:maven-project)
    mvn(org.codehaus.plexus:plexus-classworlds)
    mvn(org.codehaus.sonar:sonar-update-center-common)
    mvn(org.codehaus.woodstox:stax2-api)
    mvn(org.codehaus.woodstox:woodstox-core-lgpl)
    mvn(org.hibernate.common:hibernate-commons-annotations)
    mvn(org.hibernate:hibernate-core:3)
    mvn(org.hibernate:hibernate-ehcache:3)
    mvn(org.hibernate:hibernate-entitymanager:3)
    mvn(org.jacoco:org.jacoco.agent)
    mvn(org.jacoco:org.jacoco.core)
    mvn(org.jfree:jfreechart)
    mvn(org.mybatis:mybatis)
    mvn(org.picocontainer:picocontainer)
    mvn(org.slf4j:jcl-over-slf4j)
    mvn(org.slf4j:log4j-over-slf4j)
    mvn(org.slf4j:slf4j-api)
    mvn(xalan:xalan)
    mvn(xerces:xercesImpl)
    mvn(xpp3:xpp3)



Provides
--------
sonar:
    mvn(org.codehaus.sonar.plugins:sonar-checkstyle-plugin)
    mvn(org.codehaus.sonar.plugins:sonar-checkstyle-plugin:pom:)
    mvn(org.codehaus.sonar.plugins:sonar-cobertura-plugin)
    mvn(org.codehaus.sonar.plugins:sonar-cobertura-plugin:pom:)
    mvn(org.codehaus.sonar.plugins:sonar-cpd-plugin)
    mvn(org.codehaus.sonar.plugins:sonar-cpd-plugin:pom:)
    mvn(org.codehaus.sonar.plugins:sonar-dbcleaner-plugin)
    mvn(org.codehaus.sonar.plugins:sonar-dbcleaner-plugin:pom:)
    mvn(org.codehaus.sonar.plugins:sonar-email-notifications-plugin)
    mvn(org.codehaus.sonar.plugins:sonar-email-notifications-plugin:pom:)
    mvn(org.codehaus.sonar.plugins:sonar-jacoco-plugin)
    mvn(org.codehaus.sonar.plugins:sonar-jacoco-plugin:pom:)
    mvn(org.codehaus.sonar.plugins:sonar-l10n-en-plugin)
    mvn(org.codehaus.sonar.plugins:sonar-l10n-en-plugin:pom:)
    mvn(org.codehaus.sonar.plugins:sonar-surefire-plugin)
    mvn(org.codehaus.sonar.plugins:sonar-surefire-plugin:pom:)
    mvn(org.codehaus.sonar:sonar-batch)
    mvn(org.codehaus.sonar:sonar-batch-bootstrapper)
    mvn(org.codehaus.sonar:sonar-batch-bootstrapper:pom:)
    mvn(org.codehaus.sonar:sonar-batch-maven-compat)
    mvn(org.codehaus.sonar:sonar-batch-maven-compat:pom:)
    mvn(org.codehaus.sonar:sonar-batch:pom:)
    mvn(org.codehaus.sonar:sonar-channel)
    mvn(org.codehaus.sonar:sonar-channel:pom:)
    mvn(org.codehaus.sonar:sonar-check-api)
    mvn(org.codehaus.sonar:sonar-check-api:pom:)
    mvn(org.codehaus.sonar:sonar-colorizer)
    mvn(org.codehaus.sonar:sonar-colorizer:pom:)
    mvn(org.codehaus.sonar:sonar-core)
    mvn(org.codehaus.sonar:sonar-core:pom:)
    mvn(org.codehaus.sonar:sonar-deprecated)
    mvn(org.codehaus.sonar:sonar-deprecated:pom:)
    mvn(org.codehaus.sonar:sonar-duplications)
    mvn(org.codehaus.sonar:sonar-duplications:pom:)
    mvn(org.codehaus.sonar:sonar-graph)
    mvn(org.codehaus.sonar:sonar-graph:pom:)
    mvn(org.codehaus.sonar:sonar-java-api)
    mvn(org.codehaus.sonar:sonar-java-api:pom:)
    mvn(org.codehaus.sonar:sonar-markdown)
    mvn(org.codehaus.sonar:sonar-markdown:pom:)
    mvn(org.codehaus.sonar:sonar-maven3-plugin)
    mvn(org.codehaus.sonar:sonar-maven3-plugin:pom:)
    mvn(org.codehaus.sonar:sonar-plugin-api)
    mvn(org.codehaus.sonar:sonar-plugin-api:pom:)
    mvn(org.codehaus.sonar:sonar-squid)
    mvn(org.codehaus.sonar:sonar-squid:pom:)
    mvn(org.codehaus.sonar:sonar-ws-client)
    mvn(org.codehaus.sonar:sonar-ws-client:pom:)
    mvn(org.codehaus.sonar:sonar:pom:)
    sonar



Source checksums
----------------
https://github.com/SonarSource/sonarqube/archive/3.2.tar.gz :
  CHECKSUM(SHA256) this package     : 7f7f4dc993102b1e2f3290901f5e0298c124f40ab43e3297c1ef029d2a78b356
  CHECKSUM(SHA256) upstream package : 7f7f4dc993102b1e2f3290901f5e0298c124f40ab43e3297c1ef029d2a78b356


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -b 1163814 --plugins Java -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Created attachment 957579 [details]
licensecheck.txt

Found NON blocking issues:
please, install COPYING copyright.txt files and change license tag in LGPLv3 (see attachment 957579 [details]). Fix before import
APPROVED

Spec URL: https://msimacek.fedorapeople.org/sonar.spec
SRPM URL: https://msimacek.fedorapeople.org/sonar-3.2-2.fc20.src.rpm

Fixed license tag and installed the file.
Removed sources under different licenses to make sure they don't end up in the RPM
Split into subpackages

Thank you for the review

New Package SCM Request
=======================
Package Name: sonar
Short Description: An open platform to manage code quality
Upstream URL: http://www.sonarqube.org
Owners: msimacek mizdebsk msrb
Branches: f21
InitialCC: java-sig

Git done (by process-git-requests).

sonar-3.2-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/sonar-3.2-2.fc21

sonar-3.2-2.fc21 has been pushed to the Fedora 21 testing repository.

sonar-3.2-2.fc21 has been pushed to the Fedora 21 stable repository.