Bug 1164483
| Summary: | Review Request: nodejs-filelist - Lazy-evaluating list of files, based on globs or regexes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom Hughes <tom> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade, tom |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-json-localizer-0.0.2-1.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-01 19:03:24 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1164481 | ||
| Bug Blocks: | 956806, 1164484 | ||
|
Description
Tom Hughes
2014-11-15 17:28:27 UTC
Review:
+ Package built successful in mock (f22 x86_64)
+ rpmlint on generated rpms gave output
nodejs-filelist.noarch: W: spelling-error Summary(en_US) regexes -> regexps, reg exes, reg-exes
nodejs-filelist.noarch: W: only-non-binary-in-usr-lib
nodejs-filelist.noarch: W: dangling-symlink /usr/lib/node_modules/filelist/node_modules/minimatch /usr/lib/node_modules/minimatch
nodejs-filelist.noarch: W: dangling-symlink /usr/lib/node_modules/filelist/node_modules/utilities /usr/lib/node_modules/utilities
nodejs-filelist.src: W: spelling-error Summary(en_US) regexes -> regexps, reg exes, reg-exes
2 packages and 0 specfiles checked; 0 errors, 5 warnings.
+ Source0 verified with upstream as (sha256sum)
srpm tarball: b1c7d61ab5cea2f75d290c9cba3f418ed3debc7bd19c4bcb1e4b8e09287693cb
upstream tarball:b1c7d61ab5cea2f75d290c9cba3f418ed3debc7bd19c4bcb1e4b8e09287693cb
+ License is "ASL 2.0" and included in separate its own text file.
+ follows nodejs packaging guidelines.
Suggestions:
1) I think you should write tests in %check and not based on conditional execute %check. So,
%if 0%{?enable_tests}
%check
%nodejs_symlink_deps --check
jake test
%endif
should be
%check
%if 0%{?enable_tests}
%nodejs_symlink_deps --check
jake test
%endif
APPROVED.
New Package SCM Request ======================= Package Name: nodejs-filelist Short Description: Lazy-evaluating list of files, based on globs or regexes Upstream URL: https://github.com/mde/filelist Owners: tomh Branches: f20 f21 InitialCC: jamielinux Git done (by process-git-requests). hey, no reply on my suggestion and committed same spec?? Sorry, didn't realise you were expecting a response. I can make that change if you like - not sure why you think one way is better than the other though? That conditional can go away anyway once jake is in - it's only there to break the dependency loop that the tests require jake but this is a dependency of jake. Thanks for the reviews by the way. Thank you for detailed reply. Just wanted to know if there is any specific reason as I am used to with other way. But then no issues :) nodejs-json-localizer-0.0.2-1.fc21,nodejs-filelist-0.0.3-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-json-localizer-0.0.2-1.fc21,nodejs-filelist-0.0.3-1.fc21 nodejs-json-localizer-0.0.2-1.fc20,nodejs-filelist-0.0.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-json-localizer-0.0.2-1.fc20,nodejs-filelist-0.0.3-1.fc20 nodejs-json-localizer-0.0.2-1.fc20, nodejs-filelist-0.0.3-1.fc20 has been pushed to the Fedora 20 testing repository. nodejs-json-localizer-0.0.2-1.fc20, nodejs-filelist-0.0.3-1.fc20 has been pushed to the Fedora 20 stable repository. nodejs-json-localizer-0.0.2-1.fc21, nodejs-filelist-0.0.3-1.fc21 has been pushed to the Fedora 21 stable repository. |