Bug 1164484
| Summary: | Review Request: jake - Jake -- the JavaScript build tool for Node.js | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom Hughes <tom> |
| Component: | Package Review | Assignee: | Miroslav Suchý <msuchy> |
| Status: | CLOSED ERRATA | QA Contact: | Miroslav Suchý <msuchy> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | msuchy, package-review |
| Target Milestone: | --- | Flags: | msuchy:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | jake-8.0.10-3.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-06 02:30:01 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1164481, 1164483 | ||
| Bug Blocks: | 956806, 1164485 | ||
|
Description
Tom Hughes
2014-11-15 17:30:31 UTC
For F21+ please do: %license LICENSE See http://fedoraproject.org/wiki/Changes/Use_license_macro_in_RPMs_for_packages_in_Cloud_Image Summary - do not repeat name of the package. Just: Summary: The JavaScript build tool for Node.js jake.noarch: W: no-manual-page-for-binary jake It would be nice to create man page. Is the %license thing FPC approved yet? I noticed it in one of the packages I was reviewing recently, but couldn't find anything about it in the packaging guidelines, so thanks for that link. Looks like the proposers of that change completely dropped the ball - they got FPC approval and then didn't do anything to actually update the guidelines or the packages they were most interested in for six months. Seems things have just woken up again, but current suggestion is that it will only be recommended and it reality it seems to me that it has effectively slipped to F22 which has the additional advantage that we won't still be trying to support a release where rpm doesn't know about %license. New build with the name removed from the summary: Spec URL: http://download.compton.nu/nodejs/jake.spec SRPM URL: http://download.compton.nu/nodejs/jake-8.0.10-1.fc20.src.rpm Added manual page as well: Spec URL: http://download.compton.nu/nodejs/jake.spec SRPM URL: http://download.compton.nu/nodejs/jake-8.0.10-3.fc20.src.rpm *nod* still not in guidelines, so not mandatory. thanks for the man page. APPROVED New Package SCM Request ======================= Package Name: jake Short Description: The JavaScript build tool for Node.js Upstream URL: http://jakejs.com/ Owners: tomh Branches: f20 f21 InitialCC: jamielinux Git done (by process-git-requests). jake-8.0.10-3.fc20,nodejs-mapnik-pool-0.1.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/jake-8.0.10-3.fc20,nodejs-mapnik-pool-0.1.0-2.fc20 jake-8.0.10-3.fc21, nodejs-mapnik-pool-0.1.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/jake-8.0.10-3.fc21,nodejs-mapnik-pool-0.1.0-2.fc21 jake-8.0.10-3.fc21, nodejs-mapnik-pool-0.1.0-2.fc21 has been pushed to the Fedora 21 testing repository. jake-8.0.10-3.fc20, nodejs-mapnik-pool-0.1.0-2.fc20 has been pushed to the Fedora 20 stable repository. jake-8.0.10-3.fc21, nodejs-mapnik-pool-0.1.0-2.fc21 has been pushed to the Fedora 21 stable repository. |