Bug 1165299
| Summary: | Review Request: paratype-pt-serif-fonts - PT Serif fonts by Paratype, a pan-Cyrillic typeface | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rajeesh <rajeeshknambiar> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-24 14:53:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Rajeesh
2014-11-18 19:06:11 UTC
Review: + Package built successful in mock (f22 x86_64) - rpmlint on generated rpms gave output paratype-pt-serif-caption-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/paratype-pt-serif-caption-fonts/PTSSM_OFL.txt paratype-pt-serif-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/paratype-pt-serif-fonts/PTSSM_OFL.txt paratype-pt-serif-fonts.src: W: unexpanded-macro %description -l C %_font_pkg paratype-pt-serif-fonts.src: W: unexpanded-macro %description -l C %doc paratype-pt-serif-fonts.src: W: spelling-error %description -l en_US conf -> con, cone, cons paratype-pt-serif-fonts.src: W: spelling-error %description -l en_US ttf -> Flatt, paratype-pt-serif-fonts.src: W: spelling-error %description -l en_US txt -> text, ext, tit paratype-pt-serif-fonts.src: W: spelling-error %description -l en_US usr -> use, us, user paratype-pt-serif-fonts.src: W: spelling-error %description -l en_US appdata -> app data, app-data, tapped paratype-pt-serif-fonts.src: W: spelling-error %description -l en_US metainfo -> meta info, meta-info, infotainment paratype-pt-serif-fonts.src: W: spelling-error %description -l en_US xml -> XML, ml, x ml 3 packages and 0 specfiles checked; 0 errors, 11 warnings. + Source verified with upstream as (sha256sum) srpm tarball: e7a2a27ed0481d20973f0d3b589362d055269082e3fc4d96f81dacd58bad8dcc upstream tarball: e7a2a27ed0481d20973f0d3b589362d055269082e3fc4d96f81dacd58bad8dcc + License is "OFL" and included in its own text file. + follows fonts packaging guidelines. Suggestions to fix issues:- 1) you should take version as a date on which you packages. So it should be 20141119. Generally if there is no version in tarball then take that as snapshot package with its version as YYYYMMDD. 2) rpmlint warning wrong-file-end-of-line-encoding can be fixed in %prep sed -i "s|\r||g" PTSSM_OFL.txt Updated package. Spec URL: https://rajeeshknambiar.fedorapeople.org/spec/paratype-pt-serif-fonts.spec SRPM URL: https://rajeeshknambiar.fedorapeople.org/srpm/paratype-pt-serif-fonts-20141121-1.fc20.src.rpm Looks good. APPROVED. New Package SCM Request ======================= Package Name: paratype-pt-serif-fonts Short Description: Paratype PT Serif fonts, a pan-Cyrillic typeface Upstream URL: http://www.paratype.com/public/ Owners: rajeeshknambiar Branches: f21 f22 epel7 InitialCC: pnemade Git done (by process-git-requests). |