Bug 1165627
Summary: | Review Request: perl-XML-LibXML-Simple - XML::LibXML clone of XML::Simple::XMLin() | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Colin Macdonald <cbm> |
Component: | Package Review | Assignee: | Petr Šabata <psabata> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | package-review, psabata |
Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-Getopt-Tabular-0.3-2.fc21 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-12-06 10:39:24 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1165620 |
Description
Colin Macdonald
2014-11-19 11:45:31 UTC
#1 The same as bug 1165625, comment 3, point 3. #2 The same as bug 1165625, comment 3, point 4. #3 Missing build-time dependencies this time: perl, perl(base), perl(Carp), perl(Data::Dumper), perl(Exporter), perl(File::Basename), perl(File::Spec), perl(IO::File), perl(lib), perl(strict), perl(vars), perl(warnings). #4 You don't need to explicitly Require perl(File::Slurp::Tiny). rpmbuild automatically detects this dependency for you; it doesn't always catch everything, however, simple `use' statements like this (lib/XML/LibXML/Simple.pm:18) are not a problem. #5 Don't Require perl(Test::More). This module is used at build-time only, required by the test suite. #6 rpmbuild also finds the perl(XML::LibXML) dependency but it doesn't know what version this package needs as it doesn't say so in the code, only in the META.* files. You end up with two dependencies, one versioned, the one you explicitly list, and one unversioned, added by rpmbuild: $ rpm -qRp perl-XML-LibXML-Simple-0.94-1.fc22.noarch.rpm | grep XML::LibXML perl(XML::LibXML) perl(XML::LibXML) >= 1.64 You should filter out the unversioned dependency. See https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Perl For example, the following would do the trick for you: %global __requires_exclude %{?__requires_exclude|%__requires_exclude|}^perl\\(XML::LibXML\\)$ Updated: http://people.maths.ox.ac.uk/macdonald/fedora/perl-XML-LibXML-Simple-0.94-2.fc21.src.rpm https://raw.githubusercontent.com/cbm755/fedora-spec/master/perl-XML-LibXML-Simple.spec -------------------------- Re: #3: how do you find this? grepping through the source? Or that bit of output from rpmbuild just before `Checking for unpackaged file(s):` #4: I have still listed it in BuildRequires, I assume that's right. (In reply to Colin Macdonald from comment #2) > Updated: > > http://people.maths.ox.ac.uk/macdonald/fedora/perl-XML-LibXML-Simple-0.94-2. > fc21.src.rpm > > https://raw.githubusercontent.com/cbm755/fedora-spec/master/perl-XML-LibXML- > Simple.spec > > -------------------------- > > Re: #3: how do you find this? grepping through the source? Or that bit of > output from rpmbuild just before `Checking for unpackaged file(s):` Reading the source is the most reliable method but there are tools that can help with that, for example tangerine (as suggested in the mail I've just sent you). > #4: I have still listed it in BuildRequires, I assume that's right. Indeed, that's how it should be. New comments: #1 No need for MODULE_COMPAT in BR: perl; already mentioned in the other review. #2 No other issues :) http://people.maths.ox.ac.uk/macdonald/fedora/perl-XML-LibXML-Simple-0.94-3.fc21.src.rpm https://raw.githubusercontent.com/cbm755/fedora-spec/master/perl-XML-LibXML-Simple.spec All good now, approving. New Package SCM Request ======================= Package Name: perl-XML-LibXML-Simple Short Description: Read XML strings or files Upstream URL: http://search.cpan.org/dist/XML-LibXML-Simple/ Owners: cbm mef Branches: f21 InitialCC: perl-sig Git done (by process-git-requests). perl-Getopt-Tabular-0.3-2.fc21,perl-Business-ISSN-0.91-4.fc21,perl-Tie-Cycle-1.20-2.fc21,perl-XML-LibXML-Simple-0.94-3.fc21,perl-XML-Writer-String-0.1-5.fc21,perl-ExtUtils-LibBuilder-0.06-4.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Getopt-Tabular-0.3-2.fc21,perl-Business-ISSN-0.91-4.fc21,perl-Tie-Cycle-1.20-2.fc21,perl-XML-LibXML-Simple-0.94-3.fc21,perl-XML-Writer-String-0.1-5.fc21,perl-ExtUtils-LibBuilder-0.06-4.fc21 perl-Getopt-Tabular-0.3-2.fc21, perl-Business-ISSN-0.91-4.fc21, perl-Tie-Cycle-1.20-2.fc21, perl-XML-LibXML-Simple-0.94-3.fc21, perl-XML-Writer-String-0.1-5.fc21, perl-ExtUtils-LibBuilder-0.06-4.fc21 has been pushed to the Fedora 21 testing repository. perl-Getopt-Tabular-0.3-2.fc21, perl-Business-ISSN-0.91-4.fc21, perl-Tie-Cycle-1.20-2.fc21, perl-XML-LibXML-Simple-0.94-3.fc21, perl-XML-Writer-String-0.1-5.fc21, perl-ExtUtils-LibBuilder-0.06-4.fc21 has been pushed to the Fedora 21 stable repository. |