Bug 1165629

Summary:	Review Request: perl-Getopt-Tabular - Table-driven argument parsing for Perl 5
Product:	[Fedora] Fedora	Reporter:	Colin Macdonald <cbm>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Getopt-Tabular-0.3-2.fc21	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-12-06 10:39:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1165620

Description Colin Macdonald 2014-11-19 11:51:15 UTC

Spec URL: https://github.com/cbm755/fedora-spec/blob/master/perl-Getopt-Tabular.spec
SRPM URL: http://people.maths.ox.ac.uk/macdonald/fedora/perl-Getopt-Tabular-0.3-1.fc20.src.rpm

Description:
Getopt::Tabular is a Perl 5 module for table-driven argument parsing,
vaguely inspired by John Ousterhout's Tk_ParseArgv. All you really need to
do to use the package is set up a table describing all your command-line
options, and call &GetOptions with three arguments: a reference to your
option table, a reference to @ARGV (or something like it), and an optional
third array reference (say, to @newARGV). &GetOptions will process all
arguments in @ARGV, and copy any leftover arguments (i.e. those that are
not options or arguments to some option) to the @newARGV array. (If the
@newARGV argument is not supplied, GetOptions will replace @ARGV with the
stripped-down argument list.) If there are any invalid options, GetOptions
will print an error message and return 0.

Fedora Account System Username: cbm

This is dep for Biber, bug #1165620

I need sponsorship, but I'm not a perl user so I'm equally happy for perl people to take this one.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8180324

Comment 1 Petr Šabata 2014-11-19 14:54:31 UTC

#1 The same as bug 1165625, comment 3, point 3.

#2 The same as bug 1165625, comment 3, point 4.

#3 Consider using %{__perl} rather than /usr/bin/perl in the shebang substitution.

#4 Missing build-time deps here: perl, perl(Carp), perl(Exporter), perl(strict), perl(vars).

#5 Documentation shouldn't be executable.  Consider adding `chmod a-x demo' to %prep.

#6 Once again I see `CHECK' in your License tag... so yes, do check the license and correct it, if need be :)

Comment 2 Colin Macdonald 2014-11-19 17:00:05 UTC

Thanks.

http://people.maths.ox.ac.uk/macdonald/fedora/perl-Getopt-Tabular-0.3-2.fc21.src.rpm

https://raw.githubusercontent.com/cbm755/fedora-spec/master/perl-Getopt-Tabular.spec

Comment 3 Petr Šabata 2014-11-20 13:50:09 UTC

All points addressed, approving.

Comment 4 Colin Macdonald 2014-11-22 00:17:16 UTC

New Package SCM Request
=======================
Package Name: perl-Getopt-Tabular
Short Description: Table-driven argument parsing for Perl
Upstream URL: http://search.cpan.org/dist/Getopt-Tabular/
Owners: cbm mef
Branches: f21
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2014-11-24 13:48:07 UTC

Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-11-24 23:44:42 UTC

perl-Getopt-Tabular-0.3-2.fc21,perl-Business-ISSN-0.91-4.fc21,perl-Tie-Cycle-1.20-2.fc21,perl-XML-LibXML-Simple-0.94-3.fc21,perl-XML-Writer-String-0.1-5.fc21,perl-ExtUtils-LibBuilder-0.06-4.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Getopt-Tabular-0.3-2.fc21,perl-Business-ISSN-0.91-4.fc21,perl-Tie-Cycle-1.20-2.fc21,perl-XML-LibXML-Simple-0.94-3.fc21,perl-XML-Writer-String-0.1-5.fc21,perl-ExtUtils-LibBuilder-0.06-4.fc21

Comment 7 Fedora Update System 2014-11-25 21:25:50 UTC

perl-Getopt-Tabular-0.3-2.fc21, perl-Business-ISSN-0.91-4.fc21, perl-Tie-Cycle-1.20-2.fc21, perl-XML-LibXML-Simple-0.94-3.fc21, perl-XML-Writer-String-0.1-5.fc21, perl-ExtUtils-LibBuilder-0.06-4.fc21 has been pushed to the Fedora 21 testing repository.

Comment 8 Fedora Update System 2014-12-06 10:39:34 UTC

perl-Getopt-Tabular-0.3-2.fc21, perl-Business-ISSN-0.91-4.fc21, perl-Tie-Cycle-1.20-2.fc21, perl-XML-LibXML-Simple-0.94-3.fc21, perl-XML-Writer-String-0.1-5.fc21, perl-ExtUtils-LibBuilder-0.06-4.fc21 has been pushed to the Fedora 21 stable repository.