Bug 1165827

Summary: Remove bashism from configure.ac
Product: [Community] Virtualization Tools Reporter: Alexander Tsoy <alexander>
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: eblake, rbalakri
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-11-19 19:16:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Alexander Tsoy 2014-11-19 19:03:34 UTC
Please remove bashism from configure.ac:

- if test "x$with_firewalld" == "xyes" ; then
+ if test "x$with_firewalld" = "xyes" ; then


configure gives the following warning with dash:

...
checking for GNUTLS... yes
checking for gnutls/crypto.h... yes
checking for pkcheck... /usr/bin/pkcheck
checking whether pkcheck supports uid value... yes
./configure: 63906: test: xno: unexpected operator
checking for dtrace... no
checking for mntent.h... (cached) yes
checking for mount... /bin/mount
...

Comment 1 Eric Blake 2014-11-19 19:11:55 UTC
For issues like this, it's faster to just post your patch directly upstream to libvir-list. But I can take care of it...

Comment 2 Eric Blake 2014-11-19 19:16:05 UTC
commit aca0ae1faa163bbd60ee8df4b93ae870aa820746
Author: Eric Blake <eblake>
Date:   Wed Nov 19 12:13:14 2014 -0700

    maint: use portable shell
    
    Reported in https://bugzilla.redhat.com/show_bug.cgi?id=1165827;
    dash complains:
    
    checking for pkcheck... /usr/bin/pkcheck
    checking whether pkcheck supports uid value... yes
    ./configure: 63906: test: xno: unexpected operator
    checking for dtrace... no
    
    * configure.ac: Use '=' not '==' in test.
    
    Signed-off-by: Eric Blake <eblake>