Bug 1165996

Summary:	cmd log history should not be a hidden file
Product:	[Community] GlusterFS	Reporter:	Atin Mukherjee <amukherj>
Component:	cli	Assignee:	Atin Mukherjee <amukherj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	mainline	CC:	bugs, ggarg, gluster-bugs, kaushal, lmohanty
Target Milestone:	---	Keywords:	Patch, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1181051 (view as bug list)		Environment:
Last Closed:	2015-05-14 17:28:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1181051

Description Atin Mukherjee 2014-11-20 08:34:40 UTC

Description of problem:
all cli commands history are written in a file called .cmd_log_history which is hidden and there is no need of having it as hidden. Recently while capturing the state of the node, sosreport didn't capture this file as its hidden, probably its an enhancement to sosreport.

Version-Release number of selected component (if applicable):
Mainline

Comment 1 Anand Avati 2014-11-20 08:38:25 UTC

REVIEW: http://review.gluster.org/9150 (cli: .cmd_log_history should not be hidden) posted (#1) for review on master by Atin Mukherjee (amukherj)

Comment 2 Anand Avati 2014-11-21 04:48:35 UTC

REVIEW: http://review.gluster.org/9150 (cli: .cmd_log_history should not be hidden) posted (#2) for review on master by Atin Mukherjee (amukherj)

Comment 3 Anand Avati 2014-11-25 07:36:25 UTC

COMMIT: http://review.gluster.org/9150 committed in master by Kaushal M (kaushal) 
------
commit c6f27ed5cc9a6fafc6e6f83aff00196bc7a49d38
Author: Atin Mukherjee <amukherj>
Date:   Thu Nov 20 14:06:03 2014 +0530

    cli: .cmd_log_history should not be hidden
    
    Change-Id: I4513a2c260530855e09be64083e9344108c7a6c0
    BUG: 1165996
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/9150
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaushal M <kaushal>

Comment 4 Anand Avati 2015-02-13 11:56:28 UTC

REVIEW: http://review.gluster.org/9652 (cli: while upgrading .cmd log history should not be hidden.) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

Comment 5 Anand Avati 2015-02-13 13:01:13 UTC

REVIEW: http://review.gluster.org/9652 (build: .cmd_log_history should be renamed to cmd_history.log post upgrade.) posted (#2) for review on master by Gaurav Kumar Garg (ggarg)

Comment 6 Anand Avati 2015-02-16 11:10:03 UTC

REVIEW: http://review.gluster.org/9652 (build: .cmd_log_history should be renamed to cmd_history.log post upgrade.) posted (#3) for review on master by Gaurav Kumar Garg (ggarg)

Comment 7 Anand Avati 2015-02-16 12:19:48 UTC

REVIEW: http://review.gluster.org/9652 (build: .cmd_log_history should be renamed to cmd_history.log post upgrade.) posted (#4) for review on master by Gaurav Kumar Garg (ggarg)

Comment 8 Anand Avati 2015-02-17 05:32:52 UTC

REVIEW: http://review.gluster.org/9652 (build: .cmd_log_history should be renamed to cmd_history.log post upgrade.) posted (#5) for review on master by Gaurav Kumar Garg (ggarg)

Comment 9 Anand Avati 2015-02-17 15:46:46 UTC

COMMIT: http://review.gluster.org/9652 committed in master by Niels de Vos (ndevos) 
------
commit de6f4ce0dd894c78632bf7b2ebc00d8044fba688
Author: Gaurav Kumar Garg <ggarg>
Date:   Fri Feb 13 17:10:37 2015 +0530

    build: .cmd_log_history should be renamed to cmd_history.log post upgrade.
    
    While upgrading from glusterfs-version < 3.6 to glusterfs-3.6,
    .cmd_log_history hidden file still present in /var/log/glusterfs/ directory.
    
    With this fix it will not have .cmd_log_history hidden file and it will
    rename it to cmd_history.log file.
    
    Change-Id: I2c1658056ddd75ce923f100961205a3b78394466
    BUG: 1165996
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/9652
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Niels de Vos <ndevos>

Comment 10 Niels de Vos 2015-05-14 17:28:30 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 11 Niels de Vos 2015-05-14 17:35:43 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 12 Niels de Vos 2015-05-14 17:38:05 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 13 Niels de Vos 2015-05-14 17:45:02 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user