Bug 1167410

Summary:	Host provisioning does not send Approval email
Product:	Red Hat CloudForms Management Engine	Reporter:	Pete Savage <psavage>
Component:	Appliance	Assignee:	Tina Fitzgerald <tfitzger>
Status:	CLOSED ERRATA	QA Contact:	Nandini Chandra <nachandr>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.3.0	CC:	gmccullo, jhardy, nachandr, tcarlin, xlecauch
Target Milestone:	GA
Target Release:	5.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.4.0.0.11	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1168345 (view as bug list)		Environment:
Last Closed:	2015-06-16 12:45:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1168345

Description Pete Savage 2014-11-24 16:40:55 UTC

Description of problem: Notification of approval completion is not sent for host provisioning.


Version-Release number of selected component (if applicable): 5.3.1


How reproducible: 100%


Steps to Reproduce:
1. Perform a host provisioning
2.
3.

Actual results:
Only the 'provisioning complete' email is sent


Expected results:
'Provisioning complete' and 'Request Approved' emails should be sent


Additional info:

Logs from the appliance show that for PXE provisioning
[----] I, [2014-11-18T16:37:46.715059 #7458:4f4dedc]  INFO -- : <AutomationEngine> <AEMethod miqprovisionrequest_approved> Sending email to <evmadmin> from <evmadmin> subject: <Request ID 1 - Your Virtual Machine configuration was Approved, pending Quota Validation>
[----] I, [2014-11-18T16:43:59.488966 #19195:4c386fc]  INFO -- : Q-task_id([miq_provision_1]) <AutomationEngine> <AEMethod miqprovision_complete> Sending email to <evmadmin> from <evmadmin> subject: <Your virtual machine request has Completed - VM: xxxxxxxx_xxxxxxxx>
[----] I, [2014-11-18T17:03:50.361513 #7463:59d8118]  INFO -- : <AutomationEngine> <AEMethod miqprovisionrequest_approved> Sending email to <evmadmin> from <evmadmin> subject: <Request ID 2 - Your Virtual Machine configuration was Approved, pending Quota Validation>
[----] I, [2014-11-18T17:41:15.908981 #7463:3bf0934]  INFO -- : Q-task_id([miq_provision_2]) <AutomationEngine> <AEMethod miqprovision_complete> Sending email to <evmadmin> from <evmadmin> subject: <Your virtual machine request has Completed - VM: xxxxxxxx_xxxxxxxx>
[----] I, [2014-11-18T19:05:08.276985 #20620:6563adc]  INFO -- : <AutomationEngine> <AEMethod miqprovisionrequest_approved> Sending email to <evmadmin> from <evmadmin> subject: <Request ID 3 - Your Virtual Machine configuration was Approved, pending Quota Validation>
[----] I, [2014-11-18T19:07:42.225920 #7463:43f2d58]  INFO -- : Q-task_id([miq_provision_3]) <AutomationEngine> <AEMethod miqprovision_complete> Sending email to <evmadmin> from <evmadmin> subject: <Your virtual machine request has Completed - VM: xxxxxxxx_xxxxxxxx>

Where as for host provisioning

[----] I, [2014-11-24T14:39:49.418659 #2296:7401c9c]  INFO -- : Q-task_id([miq_host_provision_36]) <AutomationEngine> <AEMethod miqhostprovision_complete> Sending email to <template_provisioner> from <evmadmin> subject: <Your host provisioning request has Completed - Host: xxxxxxxx>
[----] I, [2014-11-24T15:21:56.277185 #12419:621b488]  INFO -- : Q-task_id([miq_host_provision_37]) <AutomationEngine> <AEMethod miqhostprovision_complete> Sending email to <template_provisioner> from <evmadmin> subject: <Your host provisioning request has Completed - Host: xxxxxxxx>
[----] I, [2014-11-24T16:25:55.781311 #2296:4f104c4]  INFO -- : Q-task_id([miq_host_provision_39]) <AutomationEngine> <AEMethod miqhostprovision_complete> Sending email to <template_provisioner> from <evmadmin> subject: <Your host provisioning request has Completed - Host: xxxxxxxx>

Comment 2 Greg McCullough 2014-11-24 19:56:19 UTC

Looking into this more I found that after restructuring of the automate model the substitution from /System/Policy/request_approved does not link to the MiqHostProvisionRequest_Approved email instance now in /Infrastructure/Host/Provisioning/Email class which is causing the issue.

To resolve this issue there needs to be a MiqHostProvisionRequest_Approved instance in /System/Policy that links to the email class.  (See MiqProvisionRequest_Approved as an example)

It would also be good to verify if any other links are missing in this area.

Comment 3 CFME Bot 2014-11-26 14:16:08 UTC

New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/be7bf8e7859e49824e9150bd865e5fd5e3cf2ae0

commit be7bf8e7859e49824e9150bd865e5fd5e3cf2ae0
Author:     Tina Fitzgerald <tfitzger>
AuthorDate: Tue Nov 25 10:17:36 2014 -0500
Commit:     Tina Fitzgerald <tfitzger>
CommitDate: Tue Nov 25 10:20:30 2014 -0500

    Add missing policy approval instances.
    
    Missing instances as a result of the automate model restructure.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1167410

 .../fixtures/ae_datastore/ManageIQ/.manifest.yaml  | 3283 ++++++++++----------
 .../miqhostprovisionrequest_approved.yaml          |   12 +
 .../servicetemplateprovisionrequest_approved.yaml  |   12 +
 .../Policy.class/vmmigraterequest_approved.yaml    |   12 +
 4 files changed, 1715 insertions(+), 1604 deletions(-)
 create mode 100644 vmdb/db/fixtures/ae_datastore/ManageIQ/System/Policy.class/miqhostprovisionrequest_approved.yaml
 create mode 100644 vmdb/db/fixtures/ae_datastore/ManageIQ/System/Policy.class/servicetemplateprovisionrequest_approved.yaml
 create mode 100644 vmdb/db/fixtures/ae_datastore/ManageIQ/System/Policy.class/vmmigraterequest_approved.yaml

Comment 4 CFME Bot 2014-11-26 17:30:46 UTC

New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=042cce1824ee40b36adbf173eda3ff80f2775868

commit 042cce1824ee40b36adbf173eda3ff80f2775868
Author:     Tina Fitzgerald <tfitzger>
AuthorDate: Tue Nov 25 10:17:36 2014 -0500
Commit:     Tina Fitzgerald <tfitzger>
CommitDate: Wed Nov 26 12:28:38 2014 -0500

    Add missing policy approval instances.
    
    Missing instances as a result of the automate model restructure.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1167410

 .../fixtures/ae_datastore/ManageIQ/.manifest.yaml  | 3283 ++++++++++----------
 .../miqhostprovisionrequest_approved.yaml          |   12 +
 .../servicetemplateprovisionrequest_approved.yaml  |   12 +
 .../Policy.class/vmmigraterequest_approved.yaml    |   12 +
 4 files changed, 1715 insertions(+), 1604 deletions(-)
 create mode 100644 vmdb/db/fixtures/ae_datastore/ManageIQ/System/Policy.class/miqhostprovisionrequest_approved.yaml
 create mode 100644 vmdb/db/fixtures/ae_datastore/ManageIQ/System/Policy.class/servicetemplateprovisionrequest_approved.yaml
 create mode 100644 vmdb/db/fixtures/ae_datastore/ManageIQ/System/Policy.class/vmmigraterequest_approved.yaml

Comment 6 Nandini Chandra 2015-05-18 21:52:38 UTC

Verified that host provisioning request approved mail is sent.

automation.log-20150516.gz:[----] I, [2015-05-15T17:15:40.455650 #4884:5a9914c]  INFO -- : <AEMethod miqhostprovisionrequest_approved> Sending email to <evmadmin> from <evmadmin> subject: <Request ID 3 - Your host provisioning request was Approved, pending Quota Validation>

Verified in 5.4.0.0.26

Comment 8 errata-xmlrpc 2015-06-16 12:45:17 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html