Bug 1167576

Summary: gnupg should be a torbrowser-launcher dependency
Product: [Fedora] Fedora Reporter: micah
Component: torbrowser-launcherAssignee: Robert Mayr <robyduck>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 20CC: lnie, pj.pandit, robyduck
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: torbrowser-launcher-0.1.7-1.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-12-06 02:30:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description micah 2014-11-25 06:00:10 UTC
Description of problem:

torbrowser-launcher depends on gnupg, but it's not marked as a dependency. When you install the torbrowser-launcher package on a fresh install of Fedora 20, without installing gnupg first, it throws an error when you run it.

Version-Release number of selected component (if applicable):

20

How reproducible:

Always.

Steps to Reproduce:
1. Install Fedora 20
2. sudo yum install torbrowser-launcher
3. torbrowser-launcher

Actual results:

Here's the error:

[micah@localhost ~]$ torbrowser-launcher 
Tor Browser Launcher
By Micah Lee, licensed under MIT
version 0.1.6
https://github.com/micahflee/torbrowser-launcher
Initializing Tor Browser Launcher
Successfully loaded mirrors from /usr/share/torbrowser-launcher/mirrors.txt
Warning: can't load mirrors from /home/micah/.config/torbrowser/mirrors.txt
Importing keys
Traceback (most recent call last):
  File "/usr/bin/torbrowser-launcher", line 30, in <module>
    torbrowser_launcher.main()
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/__init__.py", line 44, in main
    common = Common(tor_browser_launcher_version)
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/common.py", line 59, in __init__
    self.init_gnupg()
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/common.py", line 173, in init_gnupg
    self.import_keys()
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/common.py", line 178, in import_keys
    subprocess.Popen(['/usr/bin/gpg', '--homedir', self.paths['gnupg_homedir'], '--import', self.paths['erinn_key']]).wait()
  File "/usr/lib64/python2.7/subprocess.py", line 711, in __init__
    errread, errwrite)
  File "/usr/lib64/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
[micah@localhost ~]$ which gpg
/usr/bin/which: no gpg in (/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/home/micah/.local/bin:/home/micah/bin)

Expected results:

It should download and run Tor Browser Bundle.

Additional info:

Comment 1 Fedora Update System 2014-11-26 13:38:26 UTC
torbrowser-launcher-0.1.7-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/torbrowser-launcher-0.1.7-1.fc21

Comment 2 Fedora Update System 2014-11-26 13:41:04 UTC
torbrowser-launcher-0.1.7-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/torbrowser-launcher-0.1.7-1.fc20

Comment 3 lnie 2014-11-27 04:45:29 UTC
torbrowser-launcher-0.1.7-1.fc21 works

Comment 4 Fedora Update System 2014-11-27 08:34:14 UTC
Package torbrowser-launcher-0.1.7-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing torbrowser-launcher-0.1.7-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-15798/torbrowser-launcher-0.1.7-1.fc20
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2014-12-06 02:30:53 UTC
torbrowser-launcher-0.1.7-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2014-12-06 10:18:57 UTC
torbrowser-launcher-0.1.7-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.