Bug 1167601
| Summary: | "Conversion was successful" pop out even virt-p2v fails | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | tingting zheng <tzheng> | ||||
| Component: | libguestfs | Assignee: | John Eckersberg <jeckersb> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Virtualization Bugs <virt-bugs> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 7.1 | CC: | dyuan, juzhou, mbooth, mzhan, ovasik, ptoscano, rjones | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | P2V | ||||||
| Fixed In Version: | libguestfs-1.28.1-1.18.el7 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2018-09-07 19:22:55 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Background: The code that pops up the dialog is libguestfs.git/p2v/gui.c: start_conversion_thread. Presumably p2v/conversion.c:start_conversion is returning a success code even when virt-v2v fails. You can test this by running the ISO like this: truncate -s 10G empty qemu-kvm -hda empty -cdrom livecd-p2v-XXX.iso -boot d and then starting a conversion. It will fail because virt-v2v cannot convert a disk without an operating system. John's patch has been accepted upstream: https://www.redhat.com/archives/libguestfs/2014-December/msg00116.html Upstream commit: https://github.com/libguestfs/libguestfs/commit/841aa0faf3b1495fd167e32b8105b0bc6faaea60 Tested with: libguestfs-1.28.1-1.18.el7.x86_64 virt-v2v-1.28.1-1.18.el7.x86_64 livecd-p2v-201412160442.iso If conversion fails,an box will pop out with the below error: Conversion failed:virt-v2v exited with status 1. Tested with: libguestfs-1.28.1-1.36.el7.x86_64 virt-v2v-1.28.1-1.36.el7.x86_64 livecd-p2v-201505191242.iso If conversion fails,an box will pop out with the below error: Conversion failed:virt-v2v exited with status 1. Refer to the above comments,move the bug to VERIFIED. |
Created attachment 961025 [details] screenshot of virt-p2v Description "Conversion was successful" pop out even virt-p2v fails Version: virt-v2v-1.28.1-1.13.el7.x86_64 livecd-p2v-201411201732.iso How reproducible: 100% Steps to Reproduce: 1.Launch virt-p2v boot GUI via iso or virt-p2v image. 2.Use virt-p2v to convert a host without operating system installed. 3.The conversion fails and connection closed,then "Conversion was successful" pop out. Actual results： As step 3 describes. Expected results: In step 3,some info like "Conversion failed" shows. Additional info: Screenshot attached.