Bug 1167675

Summary: [GUI]>[SetupNetworks]> misleading message about unmanaged/unsynced network
Product: Red Hat Enterprise Virtualization Manager Reporter: Michael Burman <mburman>
Component: ovirt-engineAssignee: Dominik Holler <dholler>
Status: CLOSED ERRATA QA Contact: Michael Burman <mburman>
Severity: low Docs Contact:
Priority: low    
Version: 3.5.0CC: alkaplan, danken, dholler, lsurette, mkalinin, myakove, nashok, Rhev-m-bugs, srevivo
Target Milestone: ovirt-4.3.0   
Target Release: 4.3.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ovirt-engine-4.3.0_alpha Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-08 12:36:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1427836, 1520566    
Attachments:
Description Flags
screenshot none

Description Michael Burman 2014-11-25 09:37:38 UTC 
Description of problem:
[GUI]>[SetupNetworks]> misleading message about unmanaged/unsynced network 
From the message you can't understand who is the unanaged network. If you can't see on the NIC who is the unmanaged network, you can by mistake think that the network you trying to attach is the unmanaged one.
Message should be more descriptive about the unmanaged network(and unsync network as well)

Version-Release number of selected component (if applicable):
3.5.0-0.21.el6ev
3.4.4-2.2.el6ev(discovered on 3.4.4)
vdsm-4.16.7.4-1.el6ev.x86_64

How reproducible:
always

Steps to Reproduce:
1. create new network and attach to host via label
2. delete this network(on 3.4 via networks tab, on 3.5 via DC tab)
3. now you have unmanaged network. Create new network and try to assign it to the same NIC via label

Actual results:
Screen shot attached. Misleading message will displayed on the network you will try to attach to NIC.
'Invalid operation with unmanaged network: unmanaged network can only be removed'

Expected results:
Message should be more specific about the unmanaged network
Comment 1 Michael Burman 2014-11-25 09:38:13 UTC 
Created attachment 961095 [details]
screenshot
Comment 3 Yaniv Lavi 2016-05-09 10:57:00 UTC 
oVirt 4.0 Alpha has been released, moving to oVirt 4.0 Beta target.
Comment 6 Michael Burman 2017-07-12 14:13:36 UTC 
Tested on  4.2.0-0.0.master.20170711205308.git8e7af78.el7.centos
As agreed off line with Dominik, the unmanaged message should be improved as in some cases it using the wrong network in the message.
In case of trying to attach a network to NIC which still has unmanaged network attached, the tooltip and the message displaying the wrong network name, not the unmanaged one, but the one we trying to attach to the NIC. 

Steps to reproduce:

1) Attach label label1 to NIC1
2) Create net1 and attach to NIC1(not via label)
3) Remove net1 - (net1 is now unmanaged)
4) Create net2 with label1 and try to assign to NIC1

Result:

1) Try to drag the unmanaged network net1 to a different NIC on the host - message is correct - 
'Invalid operation, the unmanaged network 'net1' can only be detached'

2) Try to drag net2 to NIC1 - message incorrect -
'Invalid operation, the unmanaged network 'net2' can only be detached'

3) Hover on top of net2 - tooltip message is incorrect - 
'Invalid operation, the unmanaged network 'net2' can only be detached'
Comment 7 Michael Burman 2017-12-25 08:52:34 UTC 
(In reply to Michael Burman from comment #6)
> Tested on  4.2.0-0.0.master.20170711205308.git8e7af78.el7.centos
> As agreed off line with Dominik, the unmanaged message should be improved as
> in some cases it using the wrong network in the message.
> In case of trying to attach a network to NIC which still has unmanaged
> network attached, the tooltip and the message displaying the wrong network
> name, not the unmanaged one, but the one we trying to attach to the NIC. 
> 
> Steps to reproduce:
> 
> 1) Attach label label1 to NIC1
> 2) Create net1 and attach to NIC1(not via label)
> 3) Remove net1 - (net1 is now unmanaged)
> 4) Create net2 with label1 and try to assign to NIC1
> 
> Result:
> 
> 1) Try to drag the unmanaged network net1 to a different NIC on the host -
> message is correct - 
> 'Invalid operation, the unmanaged network 'net1' can only be detached'
> 
> 2) Try to drag net2 to NIC1 - message incorrect -
> 'Invalid operation, the unmanaged network 'net2' can only be detached'
> 
> 3) Hover on top of net2 - tooltip message is incorrect - 
> 'Invalid operation, the unmanaged network 'net2' can only be detached'

Also, the error message should include that the unmanaged network can also be removed(press 'x') and not only be detached.
Comment 8 Michael Burman 2017-12-25 08:56:09 UTC 
To be more clear, 'detached' is the wrong word, as it can't be detached really, only removed by pressing 'x' and it's why the error message still not clear enough.
Comment 11 Michael Burman 2018-11-15 13:08:31 UTC 
Verified on - 4.3.0-0.0.master.20181115085433.git293d9a1.el7
Comment 13 errata-xmlrpc 2019-05-08 12:36:47 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:1085
Comment 14 Dominik Holler 2019-11-06 15:47:45 UTC 
*** Bug 1427836 has been marked as a duplicate of this bug. ***