Bug 1167921

Summary:	p2v: No Network Connection dialog
Product:	Red Hat Enterprise Linux 7	Reporter:	Richard W.M. Jones <rjones>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.2	CC:	dyuan, huzhan, juzhou, leiwang, mbooth, mzhan, ptoscano, tzheng, wshi, xiaodwan
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	P2V
Fixed In Version:	libguestfs-1.28.1-1.36.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-19 06:57:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Richard W.M. Jones 2014-11-25 16:07:44 UTC

Description of problem:

Old virt-p2v had a Network Connection dialog, see:

http://oirase.annexia.org/booth_w_1020_guest_conversion_in_rhel.pdf
(page 7)

https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/V2V_Guide/P2V_Migration_Moving_workloads_from_Physical_to_Virtual_Machines-Converting_Physical_Machines_to_Virtual_Machines.html
(procedure 5.1,2)

I dropped this when doing the rewrite, but lack of a network
connection dialog means that virt-p2v can only ever work
with DHCP and IPv4.  No static network.  (Probably?) no IPv6.

See libguestfs.git/p2v/gui.c:

  /* Buttons. */
  gtk_dialog_add_buttons (GTK_DIALOG (conn_dlg),
                          /* _("Configure network ..."), 1, */
                          _("virt-p2v " PACKAGE_VERSION " ..."), 2,
                          _("Next"), 3,
                          NULL);

Uncomment the Configure network button (the easy bit) and
make it work (the hard bit).

Version-Release number of selected component (if applicable):

virt-v2v 1.28.1

How reproducible:

100%

Comment 2 Richard W.M. Jones 2014-11-25 16:41:54 UTC

For reference, here is the old code (in Ruby, yummy):

https://git.fedorahosted.org/cgit/virt-v2v.git/tree/p2v/client/lib/virt-p2v/netdevice.rb

Comment 4 Richard W.M. Jones 2015-05-06 15:24:19 UTC

Patches posted:
https://www.redhat.com/archives/libguestfs/2015-May/msg00016.html

Comment 5 Richard W.M. Jones 2015-05-06 17:08:36 UTC

Upstream commits:

d5305c9672054d03d0c2ccdbc532643027c63775
9b2ca08ab543e2779a3a0da5f05b7ba4a5bc7b7d
e464774a79ff9eeedcdb3fd53efd5a7898ca036e

Comment 7 Richard W.M. Jones 2015-05-09 17:01:02 UTC

The documentation wasn't updated.  I added an extra commit
containing the updated documentation, so now the full list
of commits is:

d5305c9672054d03d0c2ccdbc532643027c63775
9b2ca08ab543e2779a3a0da5f05b7ba4a5bc7b7d
e464774a79ff9eeedcdb3fd53efd5a7898ca036e
61a021713e8a93faeadc093e5c2d5064ba86059c [documentation]

Comment 9 Richard W.M. Jones 2015-05-19 17:15:42 UTC

When I started to build the virt-p2v ISO using RHEL 7.2, I realized
even more patches are needed:

d5305c9672054d03d0c2ccdbc532643027c63775
9b2ca08ab543e2779a3a0da5f05b7ba4a5bc7b7d
e464774a79ff9eeedcdb3fd53efd5a7898ca036e
61a021713e8a93faeadc093e5c2d5064ba86059c
f6dd8a3221cfa7b5aa6434cddcd0d636dd64e02b
10cb9b9545424d98687a46c23abdc0e3ff77de76

Comment 11 tingting zheng 2015-05-29 07:19:36 UTC

Tested with:
libguestfs-1.28.1-1.36.el7.x86_64
virt-v2v-1.28.1-1.36.el7.x86_64
livecd-p2v-201505191242.iso	

After virt-p2v client is lanuched,there is button "Congigure network",after click this button,there is a dialog about "Network Connections".

Tested "Add","Edit","Delete" button,it works well.

Refer to the above comments,move the bug to VERIFIED.

Comment 13 errata-xmlrpc 2015-11-19 06:57:50 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2183.html