Bug 1168206

Summary: There's a leading comma in the core-site "fs.glusterfs.volumes" property value
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Jakub Rumanovsky <jrumanov>
Component: rhs-hadoop-installAssignee: Jeff Vance <jvance>
Status: CLOSED ERRATA QA Contact: BigData QE <bigdata-qe-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rhgs-3.0CC: bchilds, dahorak, eboyd, jrumanov, jvance, matt, mkudlej, mvecera, nlevinki, rcyriac
Target Milestone: ---Keywords: ZStream
Target Release: RHGS 3.0.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 2.39-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1158997 Environment:
Last Closed: 2015-03-31 10:18:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1158997    
Bug Blocks:    

Comment 1 Jakub Rumanovsky 2014-11-26 12:25:47 UTC
Hi Jeff,

I need a little clarification, if I get the things right. You wrote that both trailing and leading commas are removed by the script. The script checks if there is comma is in the beginning or at the end and if yes script removes it, is that right?

I can only reproduce trailing comma. How can you reproduce leading comma?

Thanks for your answer in advance.

Comment 2 Jeff Vance 2014-11-26 16:50:47 UTC
I cannot dup this issue any longer but I believe that you get the leading comma when your volume name is "gv0" (due to a bug in ambari where gv0 is hard-coded as this prop value.)

Comment 3 Jakub Rumanovsky 2014-12-01 08:30:41 UTC
Ok, just to be 100% clear:

I tested script in rhs-hadoop-install 2.28,2.29 and 2.39. 

The script 2.28 add a trailing comma, if name of the volume is "gv0".
The script 2.29 add no comma, but if the comma is already there, it does not remove it.
The script in 2.39 does not create a trailing comma and removes a trailing comma if it is already there in core-site.xml

My question is: Should the script also work like the above with leading comma? (it does not matter that I can't reproduce it, I can add the comma there manually).

Thank you

Comment 4 Jeff Vance 2014-12-02 01:55:07 UTC
Jakub,  Thanks for your extra testing!  If the user manually edits the fs.glusterfs.volumes property with leading and/or trailing commas, then all leading and all trailing commas are deleted when bin/ambari_config_update.sh removes the target volume name from the list of volume names.

Comment 7 Jakub Rumanovsky 2015-03-10 14:21:16 UTC
Verified on the last version (2.44). No leading and/or trailing commas are present in core-site.xml. Moving to VERIFIED

Comment 9 errata-xmlrpc 2015-03-31 10:18:40 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2015-0761.html