Bug 1168260
| Summary: | Review Request: perl-Parse-Debian-Packages - Parse the data from a debian Packages.gz | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, psabata |
| Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Parse-Debian-Packages-0.03-2.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-05-27 16:10:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1168263 | ||
|
Description
Igor Gnatenko
2014-11-26 14:28:06 UTC
The standalone SPEC differs from the one the SRPM. It's just a different e-mail address in the changelog so I'll proceed with the review. Wrong deps, both build-time and run-time. Missing BRs: - perl, called in SPEC - perl(strict), used at %check phase Useless runtime dependency: - perl(Test::More), only used by the test suite `Debian' should be capitalized, in both Summary and %description. PERL_INSTALL_ROOT can be substituted with a more common DESTDIR. You don't need to remove empty directories (line 28). You wouldn't need to remove .packlist files (line 27) if you bumped the ExtUtils::MakeMaker dependency to 6.76+ and added NO_PACKLIST=1 to the Makefile.PL call (line 22). This would only work in F21 and newer, however. (In reply to Petr Šabata from comment #1) > The standalone SPEC differs from the one the SRPM. > It's just a different e-mail address in the changelog so I'll proceed with > the review. > > Wrong deps, both build-time and run-time. > Missing BRs: > - perl, called in SPEC > - perl(strict), used at %check phase > Useless runtime dependency: > - perl(Test::More), only used by the test suite > > `Debian' should be capitalized, in both Summary and %description. > > PERL_INSTALL_ROOT can be substituted with a more common DESTDIR. > > You don't need to remove empty directories (line 28). > > You wouldn't need to remove .packlist files (line 27) if you bumped the > ExtUtils::MakeMaker dependency to 6.76+ and added NO_PACKLIST=1 to the > Makefile.PL call (line 22). This would only work in F21 and newer, however. thank you for review. This is my first perl package, so I didn't know what's right. I'll fix all at this evening. No worries :) > You wouldn't need to remove .packlist files (line 27) if you bumped the
> ExtUtils::MakeMaker dependency to 6.76+ and added NO_PACKLIST=1 to the
> Makefile.PL call (line 22)
I want to get this lib for F20, too. What I should do?
(In reply to Igor Gnatenko from comment #4) > > You wouldn't need to remove .packlist files (line 27) if you bumped the > > ExtUtils::MakeMaker dependency to 6.76+ and added NO_PACKLIST=1 to the > > Makefile.PL call (line 22) > > I want to get this lib for F20, too. What I should do? Then ignore that point. Spec URL: https://raw.githubusercontent.com/ignatenkobrain/fuel-tmp/master/perl-Parse-Debian-Packages.spec SRPM URL: https://raw.githubusercontent.com/ignatenkobrain/fuel-tmp/master/perl-Parse-Debian-Packages-0.03-2.fc20.src.rpm fixed other errors. Still missing the `perl' BR. The rest is fine. (In reply to Petr Šabata from comment #7) > Still missing the `perl' BR. The rest is fine. ah. forget. now it should be okay. links the same. Ack, approving. Please, add perl-sig to InitialCC when requesting branches. Thanks. New Package SCM Request ======================= Package Name: perl-Parse-Debian-Packages Short Description: Parse the data from a Debian Packages.gz Upstream URL: http://search.cpan.org/dist/Parse-Debian-Packages/ Owners: ignatenkobrain Branches: f20 f21 el6 epel7 InitialCC: perl-sig Git done (by process-git-requests). Feel free to push and build the package, Igor. (In reply to Petr Šabata from comment #12) > Feel free to push and build the package, Igor. Oh, I really forget about this. Pushed to all branches. Soon will add in bodhi. Thanks! perl-Parse-Debian-Packages-0.03-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-Parse-Debian-Packages-0.03-2.el7 perl-Parse-Debian-Packages-0.03-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Parse-Debian-Packages-0.03-2.el6 perl-Parse-Debian-Packages-0.03-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Parse-Debian-Packages-0.03-2.fc21 perl-Parse-Debian-Packages-0.03-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/perl-Parse-Debian-Packages-0.03-2.fc22 perl-Parse-Debian-Packages-0.03-2.el7 has been pushed to the Fedora EPEL 7 testing repository. perl-Parse-Debian-Packages-0.03-2.fc22 has been pushed to the Fedora 22 stable repository. perl-Parse-Debian-Packages-0.03-2.fc21 has been pushed to the Fedora 21 stable repository. perl-Parse-Debian-Packages-0.03-2.el7 has been pushed to the Fedora EPEL 7 stable repository. perl-Parse-Debian-Packages-0.03-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |