Bug 1168495

Summary:	Improve the error info when pass guest doesn't exist on rhev to remote-viewer
Product:	Red Hat Enterprise Linux 7	Reporter:	tingting zheng <tzheng>
Component:	virt-viewer	Assignee:	Pavel Grunt <pgrunt>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	7.1	CC:	cfergeau, codong, dblechte, dyuan, fidencio, jjongsma, juzhou, mzhan, pgrunt, rbalakri
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	virt-viewer-0.6.0-12.el	Doc Type:	Bug Fix
Doc Text:	Cause: Try to connect to a non-existent VM is treated as an error. Consequence: A critical is displayed in the terminal. Fix: Decrease the severity level to warning instead of a critical. Result: No critical error is displayed to the user.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-03-05 13:40:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description tingting zheng 2014-11-27 06:59:36 UTC

Description
Improve the error info when pass guest doesn't exist on rhev to remote-viewer

Version:
virt-viewer-0.6.0-11.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare a guest on rhev(rhevm.example.com), and add user "admin" to virtual machine permissions
2. On remote-viewer client,pass an guest name which doesn't exist,eg:test doesn't exist on rhev.
# wget http://rhevm.example.com/ca.crt
# remote-viewer --ovirt-ca-file=ca.crt ovirt://admin%40internal.com/test
3.After input the right password,an dialog will pop out with error:"Could't open Ovirt session".
In the console,error info shows as below:
(remote-viewer:32390): remote-viewer-CRITICAL **: create_ovirt_session: assertion 'vm != NULL' failed


Actual results：
In step 3,the error info is quite confusing and not clear,actually users just pass guest which doesn't exist on rhev instead of NULL guest.

Expected results:
Improve the error info in step 3 to be more clear and not so confusing.

Additional info:

Comment 2 Christophe Fergeau 2014-11-27 09:29:52 UTC

Upstream is now showing a dialog to select the VM to connect to when an invalid VM name is given. I thought before that there had been a patch to give a better error when giving an invalid VM name, but I haven't been able to find it.

Comment 4 tingting zheng 2014-12-01 02:44:16 UTC

Tested with:
virt-viewer-0.6.0-12.el7.x86_64

Following the steps in description:

On remote-viewer client,pass an guest name which doesn't exist,eg:test doesn't exist on rhev.

After input the right password,an dialog will pop out with error:"Could't open Ovirt session".
In the console,No error info shows as description.

Refer to the above comments,move the bug to VERIFIED.

Comment 6 errata-xmlrpc 2015-03-05 13:40:17 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0295.html