Bug 1168665

Summary: RFE: allow to review and revert actions performed in guided partitioning screen by re-entering it
Product: [Fedora] Fedora Reporter: Kamil Páral <kparal>
Component: anacondaAssignee: anaconda-maint
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: anaconda-maint-list, awilliam, g.kaviyarasu, goldi_hangings, jonathan, satellitgo, vanmeeuwen+fedora, vponcova
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
bug video demonstration
none
anaconda.log
none
program.log
none
storage.log none

Description Kamil Páral 2014-11-27 14:32:19 UTC
Description of problem:
This is most probably a long standing problem, but we "discovered" it today with Vratislav Podzimek. Any actions done in the guided partitioning screen cannot be reverted, *once you left the reclaim dialog*. You can't come back to that screen and re-adjust it. That means:

* If you mark a partition for deletion (e.g. by mistake), you can't reset it to "preserve". The partition is no longer displayed in the reclaim dialog.
* If you shrink a partition too much, you can't "unshrink it/enlarge it", you can only shrink it more.

Obviously, the desirable solution would be that the reclaim dialog would display all partitions every time it is opened, including "pending operations". So if I marked a partition for deletion, it should be shown as such the next time I open the reclaim dialog, so that I could switch it back to "preserve". Similarly for partitions marked to be shrunk, I should see the full size of the partition, and I should be able to move the slider both left and right to shrink it more or less.

These changes would probably be too difficult for upcoming F21 release. Vratislav experimented with at least adding a Reset All button, similarly to what custom partition screen contains, so that users can use to reset everything to an on-disk state and therefore fix their possible mistakes this way. Might be a good idea until the proper fix is implemented (provided you agree with me on the way this should work).

Version-Release number of selected component (if applicable):
anaconda-21.48.16-1.fc21.x86_64
python-blivet-0.61.10-1.fc21.noarch
https://vpodzime.fedorapeople.org/ultimate_f21_updates.img applied

How reproducible:
always

Steps to Reproduce:
1. enter guided part
2a. mark a partition for deletion, confirm
3a. realize your mistake
4a. enter guided part again, try to undelete the partition - it's nowhere to be found

2b. mark a partition to be shrunk, confirm
3b. realize your mistake
4b. enter guided part again, try to shrink the partition less - it's not posssible, only shrink more

Additional info:
See video!

Comment 1 Kamil Páral 2014-11-27 14:33:06 UTC
Created attachment 962071 [details]
bug video demonstration

Comment 2 Kamil Páral 2014-11-27 14:33:14 UTC
Created attachment 962072 [details]
anaconda.log

Comment 3 Kamil Páral 2014-11-27 14:33:17 UTC
Created attachment 962073 [details]
program.log

Comment 4 Kamil Páral 2014-11-27 14:33:20 UTC
Created attachment 962074 [details]
storage.log

Comment 5 Adam Williamson 2019-12-12 01:07:32 UTC
Still valid exactly as described, as of F31.

Comment 6 Fedora Admin user for bugzilla script actions 2023-07-26 12:05:27 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.