Bug 1168673

Summary: Review Request: perl-Method-Signatures-Simple - Basic method declarations with signatures, without source filters
Product: [Fedora] Fedora Reporter: Petr Šabata <psabata>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Method-Signatures-Simple-1.07-1.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-12-01 14:44:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1163236    

Description Petr Šabata 2014-11-27 14:49:08 UTC 
Spec URL: https://psabata.fedorapeople.org/pkgs/perl-Method-Signatures-Simple/perl-Method-Signatures-Simple.spec
SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-Method-Signatures-Simple/perl-Method-Signatures-Simple-1.07-1.fc20.src.rpm
Description:
This module provides basic method and func keywords with simple
signatures. It's intentionally simple, and is supposed to be a
stepping stone for its bigger brothers MooseX::Method::Signatures and
Method::Signatures.  It only has a small benefit over regular subs,
so if you want more features, look at those modules.  But if you're
looking for a small amount of syntactic sugar, this might just be enough.
Fedora Account System Username: psabata
Comment 1 Jitka Plesnikova 2014-11-28 07:59:52 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Method-Signatures-Simple-1.07-1.fc22.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.20.1)
      1 perl(Devel::Declare::MethodInstaller::Simple)
      1 perl(base)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Method-Signatures-Simple-1.07-1.fc22.noarch.rpm | sort | uniq -c
      1 perl(Method::Signatures::Simple) = 1.07
      1 perl-Method-Signatures-Simple = 1.07-1.fc22
Binary provides are Ok.

$ rpmlint ./perl-Method-Signatures-Simple.spec ./perl-Method-Signatures-Simple-1.07-1.fc22.*
perl-Method-Signatures-Simple.noarch: W: spelling-error %description -l en_US func -> fun, fund, funk
perl-Method-Signatures-Simple.src: W: spelling-error %description -l en_US func -> fun, fund, funk
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok


Package APPROVED.
Comment 2 Petr Šabata 2014-11-28 09:36:16 UTC 
New Package SCM Request
=======================
Package Name: perl-Method-Signatures-Simple
Short Description: Basic method declarations with signatures, without source filters
Upstream URL: http://search.cpan.org/dist/Method-Signatures-Simple/
Owners: psabata jplesnik ppisar
Branches: 
InitialCC: perl-sig
Comment 3 Gwyn Ciesla 2014-12-01 13:47:56 UTC 
Git done (by process-git-requests).
Comment 4 Petr Šabata 2014-12-01 14:44:37 UTC 
Thanks.