Bug 1168809

Summary: logging improvement in glusterd/cli
Product: [Community] GlusterFS Reporter: Atin Mukherjee <amukherj>
Component: glusterdAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: medium    
Version: mainlineCC: bugs, gluster-bugs, jdarcy, vbellur
Target Milestone: ---Keywords: FutureFeature, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.7.0 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-05-14 17:28:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Atin Mukherjee 2014-11-28 06:23:21 UTC
This is an umbrella BZ to be used for improving the logging in glusterd component.

Comment 1 Anand Avati 2014-11-28 06:39:31 UTC
REVIEW: http://review.gluster.org/9207 (glusterd: logging improvement in txn_opinfo getter/setter function) posted (#1) for review on master by Atin Mukherjee (amukherj)

Comment 2 Anand Avati 2014-12-01 06:21:59 UTC
COMMIT: http://review.gluster.org/9207 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 4ad587a25ff218248f96696305d505c0d37c82f5
Author: Atin Mukherjee <amukherj>
Date:   Fri Nov 28 12:03:24 2014 +0530

    glusterd: logging improvement in txn_opinfo getter/setter function
    
    There is a code path (__glusterd_handle_stage_op) where glusterd_get_txn_opinfo
    may fail to get a valid transaction id if there is no volume name provided in
    the command, however if this function fails to get a txn id in op state machine
    then its a serious issue and op-sm is impacted. From debugability aspect gf_log
    () can never give the consumer of this function, so logging these failures with
    gf_log_calling_fn is must here.
    
    Change-Id: I4937a9fb20cc6a747fd30dcd9fd4936398d0602a
    BUG: 1168809
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/9207
    Reviewed-by: Avra Sengupta <asengupt>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 3 Anand Avati 2015-01-05 10:43:30 UTC
REVIEW: http://review.gluster.org/9383 (cli: logging improvements) posted (#1) for review on master by Vijay Bellur (vbellur)

Comment 4 Niels de Vos 2015-05-14 17:28:37 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:35:44 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:38:06 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:45:03 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user