Bug 1169066

Summary:	Review Request: perl-Net-RabbitMQ - Interact with RabbitMQ over AMQP using librabbitmq
Product:	[Fedora] Fedora	Reporter:	Josef Stribny <jstribny>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ddick, emmanuel, hhorak, msuchy, package-review, ppisar, psabata
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-12 12:00:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Josef Stribny 2014-11-29 19:08:28 UTC

Spec URL: http://data-strzibny.rhcloud.com/obs/perl-Net-RabbitMQ.spec
SRPM URL: http://data-strzibny.rhcloud.com/obs/perl-Net-RabbitMQ-0.2.7-1.fc22.src.rpm
Description: Net::RabbitMQ provides a simple wrapper around the librabbitmq library that allows connecting, declaring exchanges and queues, binding and unbinding queues, publishing, consuming and receiving events.
Fedora Account System Username: jstribny

There are some subtest failures, but as a newcomer to Perl, I am not sure where to report them.

Comment 1 David Dick 2014-11-30 20:01:16 UTC

Looks like this package is bundling an old (and incompatible) version of rabbitmq.

Comment 2 Petr Šabata 2014-12-02 15:22:37 UTC

Indeed, as David points out, this package is bundling librabbitmq 0.0.1.  It needs to be unbundled and the code ported to our system librabbitmq.

Also, a couple of things I noticed from a quick glance at the SPEC:

#1 Upstream URL is pointing to a "different distribution" (this is because of the two dashes in the name; upstream packaging seems a bit broken, by the way).

#2 You should use the %{version} macro in the source URL.

#3 "make test | grep 'Failed 1/6 subtests'" -- huh?  So the tests fail but you want to make it look as if they don't or what is this sorcery?

#4 A build dependency on librabbitmq isn't what you want, even after you unbundle the library.  You should depend on the devel subpackage.


This will require some work, both here and upstream.

Comment 3 Josef Stribny 2014-12-03 09:48:24 UTC

Thank you David and Petr for the input.

> #3 "make test | grep 'Failed 1/6 subtests'" -- huh?  So the tests fail but you want to make it look as if they don't or what is this sorcery?

No, I just don't know how to submit this to upstream. CPAN and Perl is still strange to me:). As I am not Perlist, I probably won't continue now in unbundling it myself.

Comment 4 David Dick 2014-12-15 19:24:36 UTC

You can report this upstream at https://rt.cpan.org/Public/Bug/Report.html?Queue=Net--RabbitM

Comment 5 Emmanuel Seyman 2015-01-15 17:21:41 UTC

Poking around CPAN, I found this paragraph in Net::AMQP::RabbitMQ's documentation:

"This module was forked from Net::RabbitMQ version 0.2.6 which uses an older version of librabbitmq, and doesn't work correctly with newer versions of RabbitMQ. The main change between this module and the original is this library uses a newer, unforked, version of librabbitmq. Version 0.4.1 to be precise."

http://search.cpan.org/~markellis/Net-AMQP-RabbitMQ-0.009000/RabbitMQ.pm

Josef, would you be willing to submit a package for that module, instead of Net::RabbitMQ?

Comment 6 Upstream Release Monitoring 2015-12-06 19:27:56 UTC

pbrobinson's scratch build of rabbitmq-java-client?#ab70721f8a01542d482131dd11f4e15ef468139b for epel7-archbootstrap and git://pkgs.fedoraproject.org/rabbitmq-java-client?#ab70721f8a01542d482131dd11f4e15ef468139b completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12090623

Comment 8 Petr Šabata 2016-08-12 12:00:55 UTC

The submitter's account's been closed.  So can be this review, I think.