Bug 1169140
| Summary: | Review Request: nodejs-util - Node.JS util module | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Piotr Popieluch <piotr1212> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-util-0.10.3-2.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-14 12:37:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Piotr Popieluch
2014-11-30 17:10:31 UTC
Review:
+ Package built successful in mock (f22 x86_64)
+ rpmlint on generated rpms gave output
nodejs-util.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-util.noarch: W: only-non-binary-in-usr-lib
nodejs-util.noarch: W: dangling-symlink /usr/lib/node_modules/util/node_modules/inherits /usr/lib/node_modules/inherits@2
nodejs-util.src: W: spelling-error %description -l en_US js -> dis, ks, j
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
+ Source verified with upstream as (sha256sum)
srpm tarball: 88033ac0a981b3c3919d7bf21e9808d0a2903c331688e4122bdd32eeea3dd6d0
upstream tarball: 88033ac0a981b3c3919d7bf21e9808d0a2903c331688e4122bdd32eeea3dd6d0
+ License is "MIT" and included in its own LICENSE file.
+ follows nodejs packaging guidelines.
Suggestions:
1) Group tag is optional, can be removed.
2) description can be same as %{summary}.
Node.js util module.
APPROVED.
New Package SCM Request ======================= Package Name: nodejs-util Short Description: Node.JS util module Upstream URL: https://github.com/defunctzombie/node-util Owners: piotrp Branches: f19 f20 f21 el6 epel7 InitialCC: piotrp Git done (by process-git-requests). nodejs-util-0.10.3-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-1.fc21 nodejs-util-0.10.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-1.fc20 nodejs-util-0.10.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-1.fc19 nodejs-util-0.10.3-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-1.el7 nodejs-util-0.10.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository. nodejs-util-0.10.3-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-2.el7 nodejs-util-0.10.3-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-2.fc19 Package built and in testing, closing bug. nodejs-util-0.10.3-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-2.fc20 nodejs-util-0.10.3-1.fc21 has been pushed to the Fedora 21 stable repository. nodejs-util-0.10.3-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-2.fc21 nodejs-util-0.10.3-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. nodejs-util-0.10.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. nodejs-util-0.10.3-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. |