Bug 1169376

Summary:	"move" disk operation badly documented, incomplete options support
Product:	[Retired] oVirt	Reporter:	Nicolas Ecarnot <nicolas>
Component:	ovirt-engine-api	Assignee:	Juan Hernández <juan.hernandez>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ori Gofen <ogofen>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.4	CC:	acanan, amureini, bugs, derez, ebenahar, ecohen, eedri, gklein, iheim, juan.hernandez, lsurette, nicolas, ogofen, rbalakri, s.kieske, yeylon, ylavi
Target Milestone:	---
Target Release:	3.5.1
Hardware:	All
OS:	All
Whiteboard:	storage
Fixed In Version:	ovirt-3.5.1_rc1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1169377 1169378 (view as bug list)		Environment:
Last Closed:	2015-03-23 12:25:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1169377, 1169378, 1193058, 1196662, 1197441

Description Nicolas Ecarnot 2014-12-01 13:38:50 UTC

Description of problem:

Trying to (cold or not) move a disk from the CLI, relying on the TAB-TAB or by reading the docs, proves that this operation is not completely supported :

----
# action disk myDisk move --storagedomain-name mySD
get() got an unexpected keyword argument 'name'
----

Juan Hernández gives this workaround :
You can however use the same operation in the context of the VM :
# action disk c6aab66a-b551-4cc5-8628-efe9622c0dce move --vm-identifier myvm --storage_domain-name mysd

and I confirm this is working.

The included doc is wrong, and so is the auto-completion.

Version-Release number of selected component (if applicable):
>> [oVirt shell (connected)]# info
>>
>> backend version: 3.4
>> sdk version    : 3.4.4
>> cli version    : 3.4.0.5
>> python version : 2.6.6.final.0

How reproducible:
Always

Steps to Reproduce:
1. Run an ovirt-shell
2. Try to move a disk following the command above
3. Cry

Actual results:
The disk is just staying there, calm.

Expected results:
The disk is moving towards the wanted storage domain.

Additional info:
See this thread :
http://lists.ovirt.org/pipermail/users/2014-November/029623.html

Comment 1 Juan Hernández 2014-12-01 13:43:27 UTC

The RSDL metadata should be fixed, then the SDKs need to be regenerated.

Comment 2 Allon Mureinik 2014-12-01 13:50:39 UTC

Daniel, can we fix the RSDL for 3.5.1?

Comment 3 Juan Hernández 2014-12-01 14:07:23 UTC

I'm fixing it.

Comment 4 Allon Mureinik 2014-12-01 14:42:44 UTC

(In reply to Juan Hernández from comment #3)
> I'm fixing it.
Break in communication here, my bad.
Thanks Juan!

Comment 5 Juan Hernández 2014-12-01 14:45:08 UTC

I decided that it was simple enough for me to fix/verify, but only after assigning it to you. Sorry for the noise.

Comment 6 Sandro Bonazzola 2015-01-15 14:14:56 UTC

This is an automated message: 
This bug should be fixed in oVirt 3.5.1 RC1, moving to QA

Comment 7 Sandro Bonazzola 2015-01-21 16:05:40 UTC

oVirt 3.5.1 has been released. If problems still persist, please make note of it in this bug report.

Comment 8 Eyal Edri 2015-02-26 12:32:05 UTC

this ovirt bug was fixed during 3.5.1 cycle and is included in the build, and therefore should be verified.

Comment 9 Nicolas Ecarnot 2015-02-27 07:23:40 UTC

Yesterday I upgraded from 3.4.1 to 3.5.1, and tried to use the exact same command as the one which was failing when I opened this bug.

It is working immediately.

Thank you for this bug fix.

Comment 10 Ori Gofen 2015-03-16 13:00:50 UTC

Hey Juan, I have executed several move operations, via rhevm shell using the syntax descripted at comment #1:
action disk $NAME move --storagedomain-name $SD_NAME

The good part is that it works fine, the mediocre part is that the parameter "--storagedomain-name" still does not appear as a valid 'TAB TAB completion' which could make it hard for our costumers to execute the right syntax, is it going to be merged?

Comment 11 Juan Hernández 2015-03-16 13:12:04 UTC

Ori, what version of the Python SDK are you using? This was fixed in ovirt-engine-sdk-python-3.5.1.0, see bug 1169377.

Comment 12 Ori Gofen 2015-03-18 12:08:53 UTC

the version was not correct, the py-sdk I was using was rhevm3.5.1 and this bug should be verified with ovirt3.5.1, sorry

Comment 13 Ori Gofen 2015-03-19 08:54:14 UTC

Well to tell the truth I'm a little bit baffled here, what should be the right build to verify this bug Eyal?

Comment 15 Ori Gofen 2015-03-22 11:04:46 UTC

verified on vt14.1: rhevm-sdk-python-3.5.2.0-1.el6ev.noarch