Bug 1169784

Summary:	`gluster peer probe hostname` fails when hostname contains '_'
Product:	[Community] GlusterFS	Reporter:	Kaleb KEITHLEY <kkeithle>
Component:	glusterd	Assignee:	ankit <anraj>
Status:	CLOSED NOTABUG	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	amukherj, anraj, bugs, junli.li
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1169707	Environment:
Last Closed:	2016-09-28 10:34:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1169707
Bug Blocks:

Description Kaleb KEITHLEY 2014-12-02 12:40:43 UTC

+++ This bug was initially created as a clone of Bug #1169707 +++

Description of problem:
`gluster peer probe hostname` fails when hostname contains '_'

Version-Release number of selected component (if applicable):
3.4.2-1

How reproducible:
always

Steps to Reproduce:
1.set a host'name to "n_***", such as "n_node";
2.on another node, execute `gluster peer probe n_node`
3.

Actual results:
2. 
n_node is an invalid address
Usage: peer probe <HOSTNAME>


Expected results:
2.
peer probe: success


Additional info:

--- Additional comment from Kaleb KEITHLEY on 2014-12-02 07:40:09 EST ---

RFC1035 indicates that only 0-9A-Za-z and '-' are legal characters in a hostname, however it was agreed during review that we should relax our hostname checking

Comment 1 Worker Ant 2016-09-27 18:16:23 UTC

REVIEW: http://review.gluster.org/15582 (libglusterfs: relaxation of hostname while doing peer probing) posted (#1) for review on master by ankitraj

Comment 2 ankit 2016-09-28 10:34:37 UTC

This bug is against the RFC rule.
http://stackoverflow.com/questions/2180465/can-domain-name-subdomains-have-an-underscore-in-it