Bug 1169975

Summary: COS memory leak when rebuilding the cache
Product: Red Hat Enterprise Linux 6 Reporter: mreynolds
Component: 389-ds-baseAssignee: Noriko Hosoi <nhosoi>
Status: CLOSED ERRATA QA Contact: Viktor Ashirov <vashirov>
Severity: high Docs Contact:
Priority: high    
Version: 6.6CC: amsharma, jgalipea, mreynolds, nkinder, rmeggins
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: 389-ds-base- Doc Type: Bug Fix
Doc Text:
Cause: An internal schema list was not completed freed when the COS cache is released Consequence: A memory leak. Fix: Free the entire schema list from the COS cache. Result: No memory leak
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-07-22 06:36:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Description Flags
valgrind output none

Description mreynolds 2014-12-02 21:39:57 UTC
This bug is created as a clone of upstream ticket:

When the COS cache is released, the schema cache is not correctly freed.  We leak memory every time the cache is rebuilt.

==24017== 102 (72 direct, 30 indirect) bytes in 3 blocks are definitely lost in loss record 1,277 of 2,056
==24017==    at 0x4C2745D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==24017==    by 0x4E854CA: slapi_ch_malloc (ch_malloc.c:155)
==24017==    by 0x111F0244: cos_cache_add_attrval (cos_cache.c:1532)
==24017==    by 0x111F2A48: cos_cache_schema_build (cos_cache.c:2751)
==24017==    by 0x111EE46B: cos_cache_create (cos_cache.c:498)
==24017==    by 0x111EE32E: cos_cache_wait_on_change (cos_cache.c:451)
==24017==    by 0x718FE3A: ??? (in /usr/lib64/libnspr4.so)
==24017==    by 0x77CEEE4: start_thread (in /usr/lib64/libpthread-2.18.so)
==24017==    by 0x7AD8B8C: clone (in /usr/lib64/libc-2.18.so)

Comment 2 mreynolds 2014-12-04 21:17:03 UTC
Fixed upstream.

Verification steps:

[1]  setup DS using valgrind
[2]  Add 2 COS templates and definitions
[3]  Modify the template in any way
[4]  stop theserver and check the valgrind output file for "cos_cache_add_attrval"
[5]  If it's not found the leak is fixed.

Comment 4 Amita Sharma 2015-03-05 07:30:33 UTC
[root@qe-blade-09 export]# ldapmodify -x -a -D "cn=Directory Manager" -w Secret123 -p 389 -h localhost -f /export/1169975COS.ldif 
adding new entry "cn=cosTemplateExample,ou=People,dc=example,dc=com"

adding new entry "cn=cosTemplateExample1,ou=People,dc=example,dc=com"

adding new entry "cn=cosPointer,ou=People,dc=example,dc=com"

adding new entry "cn=cosPointer1,ou=People,dc=example,dc=com"

[root@qe-blade-09 export]# ldapmodify -x -D "cn=Directory Manager" -w Secret123 -p 389 -h localhost << EOF
dn: cn=cosTemplateExample,ou=People,dc=example,dc=com
changetype: modify
replace: st
st: AND

modifying entry "cn=cosTemplateExample,ou=People,dc=example,dc=com"

[root@qe-blade-09 export]# service dirsrv stop
Shutting down dirsrv: 
    qe-blade-09...[  OK  

there is no memory leak for COS, but there are other leaks. PFA for the valgrind output and suggest, if they required to be fixed.
I am marking this bug as VERIFIED as no leaks for COS found.

Comment 5 Amita Sharma 2015-03-05 07:31:28 UTC
Created attachment 998213 [details]
valgrind output

Comment 6 mreynolds 2015-03-23 11:57:07 UTC
Hi Amita,

You can mark this as verified.  There are other virtual attribute search leaks, but there is already a ticket open for those.  The rest of the leaks can  be ignored and are harmless (startup) leaks.


Comment 7 errata-xmlrpc 2015-07-22 06:36:23 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.