Bug 1170226
Summary: | xulrunner 31 breaks spice-xpi build | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Christophe Fergeau <cfergeau> |
Component: | xulrunner | Assignee: | Martin Stransky <stransky> |
Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> |
Severity: | low | Docs Contact: | |
Priority: | unspecified | ||
Version: | 7.1 | CC: | cfergeau, desktop-qa-list, rbalakri, tlavigne, tpelka, vbenes, vehrlich |
Target Milestone: | rc | Keywords: | TestBlocker |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | xulrunner-31.4.0-1.el7_0 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | 1165784 | Environment: | |
Last Closed: | 2015-01-19 15:50:20 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1165784 | ||
Bug Blocks: |
Description
Christophe Fergeau
2014-12-03 14:21:36 UTC
This helps with the build errors from http://download.devel.redhat.com/brewroot/work/tasks/953/8350953/build.log : /usr/bin/python: can't open file '/usr/lib64/xulrunner-devel-31.1.0/sdk/bin/header.py': [Errno 2] No such file or directory /usr/bin/python: can't open file '/usr/lib64/xulrunner-devel-31.1.0/sdk/bin/typelib.py': [Errno 2] No such file or directory Adding -std=gnu++1y to the CXXFLAGS is still needed. (In reply to Christophe Fergeau from comment #4) > Adding -std=gnu++1y to the CXXFLAGS is still needed. Why do you need this? We get some errors including nsError.h without that: In file included from nsScriptablePeer.cpp:54:0: /usr/include/xulrunner-31.1.0/nsError.h:187:1: warning: identifier 'static_assert' is a keyword in C++11 [-Wc++0x-compat] static_assert(((nsresult)0) < ((nsresult)-1), ^ In file included from nsScriptablePeerBase.cpp:42:0: /usr/include/xulrunner-31.1.0/nsError.h:187:1: warning: identifier 'static_assert' is a keyword in C++11 [-Wc++0x-compat] static_assert(((nsresult)0) < ((nsresult)-1), ^ /usr/include/xulrunner-31.1.0/nsError.h:187:14: error: expected constructor, destructor, or type conversion before '(' token static_assert(((nsresult)0) < ((nsresult)-1), ^ /usr/include/xulrunner-31.1.0/nsError.h:189:14: error: expected constructor, destructor, or type conversion before '(' token static_assert(sizeof(nsresult) == sizeof(uint32_t), ^ make[5]: *** [libnsISpicec_la-nsScriptablePeerBase.lo] Error 1 make[5]: *** Waiting for unfinished jobs.... It's easy to workaround in spice-xpi btw, and we've already done so in the latest build. I wonder why do you need the -std=gnu++1y flags. Firefox itself is built with -std=gnu++0x (see http://download.devel.redhat.com/brewroot/packages/firefox/31.4.0/1.el7_0/data/logs/x86_64/build.log) and static_assert() is there used on many places. Do you have specified the "-Wc++0x-compat" keyword (which seems to act here). The static_assert macro is a part of C++0x as you can see at https://gcc.gnu.org/gcc-4.3/cxx0x_status.html (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2004/n1720.html) (In reply to Martin Stransky from comment #10) > I wonder why do you need the -std=gnu++1y flags. > > Firefox itself is built with -std=gnu++0x Oh I was talking about -std=gnu++1x VS not specifying any -std=xxx in the CXXFLAGS. spice-xpi used to build without any need for -std=xxx. If I use -std=gnu++0x, the build is fine as well. > > Do you have specified the "-Wc++0x-compat" keyword (which seems to act here). Yes, but it seems unrelated to the build failure (not using -Werror, and the build still fails with -Wno-c++0x-compat). See http://download.devel.redhat.com/brewroot/work/tasks/4976/8564976/build.log for a failed build log with -Wc++0x-compat disabled. Adding -std=gnu++0x (I guess many other -std=xxx values work too) is enough to fix this. Ahh, I see. Okay, I'll add the compatibility flags there then. This bug was verified during spice-xpi testing in house. |