Bug 1170405

Description of problem:
If the directory or file system where the apply-updates utility is extracted has insufficient space or ACL rights, the apply-updates command can leave the agent or server in a corrupted state. 

This is due to the backup failing. For example, the move command is not able to actually write the file in its destination so it therefore doesn't remove it from its source. This means that the files in the file removal list do not actually get removed when the update is applied.

Version-Release number of selected component (if applicable):
3.2.3

How reproducible:
Always

Steps to Reproduce:
1. Install JBoss ON 3.2.
2. Extract the update-03 utility to a location that has less then 300 MB of free space.
3. Run the apply-updates command on the JBoss ON installation.

Actual results:
Update did not get properly applied and old copies of API or other important lib files were left in place allowing them to be picked up post-update. update.log is incomplete and/or contains messages similar to:

	 mv /opt/jboss/jboss-on/jon-server/modules/org/rhq/server-startup/main/deployments/rhq.ear/rhq-core-domain-ejb3.jar/org/rhq/core/domain/measurement/MeasurementOOB.java /data/jon-server-3.2.0.GA-update-03/.old/modules/org/rhq/server-startup/main/deployments/rhq.ear/rhq-core-domain-ejb3.jar/org/rhq/core/domain/measurement
	 mv /opt/jboss/jboss-on/jon-server/modules/org/rhq/server-startup/main/deployments/rhq.ear/rhq-downloads/rhq-agent/rhq-enterprise-agent-4.9.0.JON320GA.jar /data/jon-server-3.2.0.GA-update-03/.old/modules/org/rhq/server-startup/main/deployments/rhq.ear/rhq-downloads/rhq-agent
mv: error writing ‘/data/jon-server-3.2.0.GA-update-03/.old/modules/org/rhq/server-startup/main/deployments/rhq.ear/rhq-downloads/rhq-agent/rhq-enterprise-agent-4.9.0.JON320GA.jar’: No space left on device
mv: failed to extend ‘/data/jon-server-3.2.0.GA-update-03/.old/modules/org/rhq/server-startup/main/deployments/rhq.ear/rhq-downloads/rhq-agent/rhq-enterprise-agent-4.9.0.JON320GA.jar’: No space left on device
	 mv /opt/jboss/jboss-on/jon-server/modules/org/rhq/server-startup/main/deployments/rhq.ear/rhq-downloads/rhq-client/rhq-remoting-cli-4.9.0.JON320GA.zip /data/jon-server-3.2.0.GA-update-03/.old/modules/org/rhq/server-startup/main/deployments/rhq.ear/rhq-downloads/rhq-client
mv: error writing ‘/data/jon-server-3.2.0.GA-update-03/.old/modules/org/rhq/server-startup/main/deployments/rhq.ear/rhq-downloads/rhq-client’: No space left on device
mv: failed to extend ‘/data/jon-server-3.2.0.GA-update-03/.old/modules/org/rhq/server-startup/ma

Expected results:
No failure messages and file system in agent and server match the expected contents for a post-updated component.

Additional info:
First, the backup should not be written to the utilities location. Instead, it should be stored in the target components base directory either in the .patched location with a date or other indication of when it was executed--perhaps even the patch it is associated with.

Second, if the backup fails,  perhaps the upgrade should fail. This is where a --force option comes in handy or other command-line argument that can tell the update to continue without backing up.

Third, instead of the mv, a cp should be done followed by a delete. We should also check to see if the file exists before attempting the copy.