Bug 1170410

Summary: git-review's man page needs help
Product: [Fedora] Fedora Reporter: Jeff Morriss <jeff.morriss>
Component: git-reviewAssignee: Pete Zaitcev <zaitcev>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: lnie, zaitcev
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: git-review-1.24-3.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-12-21 07:24:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jeff Morriss 2014-12-04 02:32:15 UTC
Description of problem:
The new version of git review's man page is almost uselessly unreadable.  For example here is its description of the "-d" argument:

~~~
     The following options are available:
     Download change from Gerrit into a local branch. The branch will be named after the patch author and the name of a topic.  If the local branch
     already exists, it will attempt to update with the latest patchset for this change.
     Apply change from Gerrit and commit into the current local branch ("cherry pick").  No additional branch is created.
~~~

Note that it doesn't actually tell you that the option it's describing is "-d"!

Version-Release number of selected component (if applicable):
git-review-1.24-2.fc19.noarch

I also had the same problem on a mostly-up-to-date fc20 system.

How reproducible:
100%

Steps to Reproduce:
1. man git-review (or "git help review")
2. Read the man page.
3. Try to figure out which option does what.

Actual results:
I can't figure out what "-d" does from reading the man page.

Expected results:
I *can* figure out what "-d" does from reading the man page.

Additional info:
Workaround is to run "git review -h" to list the options and what they do.

Comment 1 Pete Zaitcev 2014-12-04 05:56:10 UTC
Yeah, it's super weird. The upstream version of the man page is fine,
but our installed version is all broken.

Comment 2 Fedora Update System 2014-12-12 04:55:48 UTC
git-review-1.24-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/git-review-1.24-3.fc21

Comment 3 lnie 2014-12-12 09:09:33 UTC
git-review-1.24-3.fc21 works

Comment 4 Pete Zaitcev 2014-12-12 17:23:09 UTC
I'll push F20 too once this circles around. Poke me if I forget.

Comment 5 Fedora Update System 2014-12-13 09:40:58 UTC
Package git-review-1.24-3.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing git-review-1.24-3.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-16834/git-review-1.24-3.fc21
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2014-12-21 00:07:15 UTC
git-review-1.24-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/git-review-1.24-3.fc20

Comment 7 Fedora Update System 2014-12-22 02:33:04 UTC
git-review-1.24-3.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2015-01-01 08:55:35 UTC
git-review-1.24-3.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.