Bug 1170629

Ihar,
just a few annotations before I'll do a proper review.
- please adjust python macros: https://fedoraproject.org/wiki/Packaging:Python#Macros
- setuptools is missing from builddepencencies
- please remove egg-info in %prep section
- please be more specific in files section. To avoid accidental inclusion of other files, try to narrow that list down as much as possible.
e.g %{python_sitelib}/ncclient 
won't hurt.

Since tests are included, could you please implement a %check section?

Matthias, thanks a lot for your comments. I've updated the spec to reflect your suggestions:

Spec URL: http://people.redhat.com/~ihrachys/python-ncclient.spec
SRPM URL: http://people.redhat.com/~ihrachys/python-ncclient-0.4.2-2.fc20.src.rpm

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "Unknown or generated". 39 files have unknown license.
     Detailed output of licensecheck in /home/mrunge/review/1170629-python-
     ncclient/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 522240 bytes in 74 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: Uses parallel make %{?_smp_mflags} macro.
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-ncclient-0.4.2-2.fc21.noarch.rpm
          python-ncclient-0.4.2-2.fc21.src.rpm
python-ncclient.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-ncclient/html/_static/jquery.js
python-ncclient.noarch: W: hidden-file-or-dir /usr/share/doc/python-ncclient/html/.buildinfo
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/get-config-jnpr.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/unknown-rpc.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/edit-config-std.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/edit-config-jnpr-text.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/get-xnm-information.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/execute-rpc-string.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/pubkey-auth.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/get-configuration-matching.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/edit-config-jnpr-set.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/compare-config-jnpr.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/get-configuration-jnpr.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/edit-config-bgp-peer.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/edit-config-jnpr.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/request-reboot.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/delete-config-jnpr.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/get-inventory.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/command-jnpr.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/execute-rpc.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/edit-config-text-std.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/get-session-params.py /usr/bin/env
python-ncclient.src:73: W: macro-in-%changelog %{python2_sitelib}
2 packages and 0 specfiles checked; 0 errors, 23 warnings.




Rpmlint (installed packages)
----------------------------
<mock-chroot>[root@turing /]# rpmlint python-ncclient
python-ncclient.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-ncclient/html/_static/jquery.js
python-ncclient.noarch: W: hidden-file-or-dir /usr/share/doc/python-ncclient/html/.buildinfo
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/get-config-jnpr.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/unknown-rpc.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/edit-config-std.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/edit-config-jnpr-text.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/get-xnm-information.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/execute-rpc-string.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/pubkey-auth.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/get-configuration-matching.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/edit-config-jnpr-set.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/compare-config-jnpr.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/get-configuration-jnpr.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/edit-config-bgp-peer.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/edit-config-jnpr.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/request-reboot.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/delete-config-jnpr.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/get-inventory.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/command-jnpr.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/execute-rpc.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/edit-config-text-std.py /usr/bin/env
python-ncclient.noarch: W: doc-file-dependency /usr/share/doc/python-ncclient/examples/juniper/get-session-params.py /usr/bin/env
1 packages and 0 specfiles checked; 0 errors, 22 warnings.
<mock-chroot>[root@turing /]# echo 'rpmlint-done:'



Requires
--------
python-ncclient (rpmlib, GLIBC filtered):
    /usr/bin/env
    libxml2-python
    libxslt-python
    python(abi)
    python-lxml
    python-paramiko



Provides
--------
python-ncclient:
    python-ncclient



Source checksums
----------------
https://github.com/leopoul/ncclient/archive/v0.4.2.tar.gz#/ncclient-0.4.2.tar.gz :
  CHECKSUM(SHA256) this package     : 5430132964a5e51e7b06b29c8a7bb2c0c216d547d01c7c88bd757ea064cb2237
  CHECKSUM(SHA256) upstream package : 5430132964a5e51e7b06b29c8a7bb2c0c216d547d01c7c88bd757ea064cb2237




Doc file dependencies are false positive reports, they are included in examples, not used at runtime at all.


Package approved.


Please be sure to remove /usr/share/doc/python-ncclient/html/.buildinfo before importing this into git. (in build section, remove that dir.

New Package SCM Request
=======================
Package Name: python-ncclient
Short Description: Python library for NETCONF clients
Upstream URL: https://pypi.python.org/pypi/ncclient
Owners: ihrachyshka
Branches: f20 f21 el6 epel7
InitialCC: ihrachyshka

Git done (by process-git-requests).

python-ncclient-0.4.2-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-ncclient-0.4.2-2.fc21

python-ncclient-0.4.2-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/python-ncclient-0.4.2-2.el7

python-ncclient-0.4.2-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-ncclient-0.4.2-2.el6

python-ncclient-0.4.2-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-ncclient-0.4.2-2.fc20

python-ncclient-0.4.2-2.fc21 has been pushed to the Fedora 21 stable repository.

python-ncclient-0.4.2-2.fc20 has been pushed to the Fedora 20 stable repository.

python-ncclient-0.4.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository.

python-ncclient-0.4.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository.