Bug 1170802
| Summary: | Review Request: nodejs-relateurl - Minify URLs by converting them from absolute to relative | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Piotr Popieluch <piotr1212> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
petersen: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-relateurl-0.2.5-3.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-27 01:00:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1175878, 1176445 | ||
|
Description
Piotr Popieluch
2014-12-04 22:07:20 UTC
Review: + Package built successful in mock (f22 x86_64) + rpmlint on generated rpms gave output nodejs-relateurl.noarch: W: spelling-error Summary(en_US) Minify -> Magnify nodejs-relateurl.noarch: W: spelling-error %description -l en_US Minify -> Magnify nodejs-relateurl.noarch: W: only-non-binary-in-usr-lib nodejs-relateurl.src: W: spelling-error Summary(en_US) Minify -> Magnify nodejs-relateurl.src: W: spelling-error %description -l en_US Minify -> Magnify 2 packages and 0 specfiles checked; 0 errors, 5 warnings. + Source verified with upstream as (sha256sum) srpm tarball: dbcffd89b3830974076df9c9531c9705fdb5215ecf0d5c98f3afd6052bcbacaf upstream tarball: dbcffd89b3830974076df9c9531c9705fdb5215ecf0d5c98f3afd6052bcbacaf + License is "MIT" - License text file is not available. + follows nodejs packaging guidelines. Suggestions: 1) Group tag is optional 2) you can also write BuildRequires: npm(chai) 3)Many npm modules don't used to have LICENSE text file included. You should ask upstream to add license text file and release new upstream version. Thnx, fixed suggestions, requested license file: https://github.com/stevenvachon/relateurl/issues/2 new release: Spec URL: https://piotrp.fedorapeople.org/nodejs-relateurl.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-relateurl-0.2.5-2.fc21.src.rpm License file is merged upstream, it is included as Source1. Spec URL: https://piotrp.fedorapeople.org/nodejs-relateurl.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-relateurl-0.2.5-3.fc21.src.rpm Looks good now. But you can also write BR: specific to tests like
%if 0%{?enable_tests}
BuildRequires: mocha
BuildRequires: npm(chai)
%endif
APPROVED.
Thank you for review. Will add the enable_tests condition before pushing. New Package SCM Request ======================= Package Name: nodejs-relateurl Short Description: - Minify URLs by converting them from absolute to relative Upstream URL: https://github.com/stevenvachon/relateurl Owners: piotrp Branches: f20 f21 el6 epel7 Git done (by process-git-requests). nodejs-relateurl-0.2.5-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-relateurl-0.2.5-3.fc21 nodejs-relateurl-0.2.5-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-relateurl-0.2.5-3.fc20 nodejs-relateurl-0.2.5-3.fc20 has been pushed to the Fedora 20 testing repository. package built, closing. nodejs-relateurl-0.2.5-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-relateurl-0.2.5-3.el7 nodejs-relateurl-0.2.5-3.fc21 has been pushed to the Fedora 21 stable repository. nodejs-relateurl-0.2.5-3.fc20 has been pushed to the Fedora 20 stable repository. nodejs-relateurl-0.2.5-3.el7 has been pushed to the Fedora EPEL 7 stable repository. |