Bug 117097

Summary: wrong number of parameters in function calls
Product: [Fedora] Fedora Reporter: d.binderman
Component: texinfoAssignee: Tim Waugh <twaugh>
Status: CLOSED RAWHIDE QA Contact: Ben Levenson <benl>
Severity: medium Docs Contact:
Priority: medium    
Version: 2   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-03-02 16:18:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description d.binderman 2004-02-28 14:26:28 UTC 
Description of problem:

I just tried to compile Core2 Test1 package texinfo-4.6-1

The compiler said

1.

infomap.c(161): warning #140: too many arguments in function call

The source code is

          ks = find_function_keyseq (map, i, rootmap, NULL);

but, earlier in the same file

static FUNCTION_KEYSEQ *
find_function_keyseq (map, c, rootmap)
  Keymap map;
  int c;
  Keymap rootmap;
{

Four parameters supplied, only three accepted. Suggest delete trailing
NULL on call.

2.

cmds.c(978): warning #165: too few arguments in function call
cmds.c(982): warning #165: too few arguments in function call

Broken source code is
void
cm_w (arg, start, end)
     int arg, start, end;
{
  if (arg == START)
    non_splitting_words++;
  else
    non_splitting_words--;
}

Suggest dropping start & end, since they are not used.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Tim Waugh 2004-03-02 16:18:22 UTC 
Point 2 is incorrect I think.

Why not report these kind of cosmetic things upstream, unless there is
really a detrimental symptom?