Bug 1171260
| Summary: | Review Request: rubygem-jmespath - JMESPath - Ruby Edition | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | František Dvořák <valtri> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-jmespath-1.0.2-2.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-02-15 13:57:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1149410 | ||
|
Description
František Dvořák
2014-12-05 18:49:06 UTC
Taking. I would appreciate it if you would review my review request (bug 1186572) For 1.0.2-1:
Well, very simple package. Now a few questions.
* BR: rubygem(simplecov)
- Is this BR needed? (any coverage tests?)
* Tweaking multi_json dependency
- does not seem to be working. Please check this.
(and is this needed?)
* %setup - unpacking %{SOURCE1}
----------------------------------------------------
%setup -q -D -T -n %{gem_name}-%{version}
tar -xzf %{SOURCE1}
----------------------------------------------------
- "%setup -q -D -T -n %{gem_name}-%{version} -a 1" is more smart.
(In reply to Mamoru TASAKA from comment #2) > For 1.0.2-1: > > Well, very simple package. Now a few questions. > > * BR: rubygem(simplecov) > - Is this BR needed? (any coverage tests?) > Yes, it looks like simplecov is not really needed, although it needs to remove some 4 lines: sed -i spec/compliance_spec.rb spec/spec_helper.rb -e '/simplecov\|SimpleCov/d' > * Tweaking multi_json dependency > - does not seem to be working. Please check this. > (and is this needed?) > Nice catch! Removed. I misread the '~> 1.0' string. > * %setup - unpacking %{SOURCE1} > ---------------------------------------------------- > %setup -q -D -T -n %{gem_name}-%{version} > tar -xzf %{SOURCE1} > ---------------------------------------------------- > - "%setup -q -D -T -n %{gem_name}-%{version} -a 1" is more smart. OK, '-a 1' will be better. New version: Spec URL: http://scientific.zcu.cz/fedora/rubygem-jmespath-1.0.2-2/rubygem-jmespath.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-jmespath-1.0.2-2/rubygem-jmespath-1.0.2-2.fc22.src.rpm Thu Jan 29 2015 František Dvořák <valtri.cz> - 1.0.2-2 - Removed rubygem(simplecov) BR - Cleanups Okay. * spec file / srpm clean * can be built cleanly * generated binary clean * can be installed * at least the following works $ ruby -e "require 'jmespath' ; puts JMESPath::VERSION" 1.0.2 ------------------------------------------------------- This package (rubygem-jmespath) is APPROVED by mtasaka ------------------------------------------------------- New Package SCM Request ======================= Package Name: rubygem-jmespath Short Description: JMESPath - Ruby Edition Upstream URL: http://github.com/trevorrowe/jmespath.rb Owners: valtri Branches: f20 f21 epel7 InitialCC: Git done (by process-git-requests). rubygem-jmespath-1.0.2-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/rubygem-jmespath-1.0.2-2.fc21 rubygem-jmespath-1.0.2-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-jmespath-1.0.2-2.fc20 rubygem-jmespath-1.0.2-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/rubygem-jmespath-1.0.2-2.el7 rubygem-jmespath-1.0.2-2.fc21 has been pushed to the Fedora 21 testing repository. rubygem-jmespath-1.0.2-2.fc20 has been pushed to the Fedora 20 stable repository. rubygem-jmespath-1.0.2-2.fc21 has been pushed to the Fedora 21 stable repository. rubygem-jmespath-1.0.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. |