Bug 1171263

Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-entities.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: 1118cdb833068b6450d48946fb53cece6e41a3e95b29d24871898cb7a71ffced
upstream tarball:  1118cdb833068b6450d48946fb53cece6e41a3e95b29d24871898cb7a71ffced

- License is "BSD" and not "MIT. 

+ License text is included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional, can be removed.

2) Fix license tag

oops! my bad. I have many tabs open and I wrote wrong review above. 
Here is correct one

Review:
- Package built successful in mock (f22 x86_64)

+ Source istanbul-0.3.2.tgz verified with upstream as (sha256sum)
srpm tarball: 95f3d546e15b110ea75466058c6247d1fb940771ae640eb49d02ad124995920d
upstream tarball:  95f3d546e15b110ea75466058c6247d1fb940771ae640eb49d02ad124995920d

+ License is "BSD" and included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional, can be removed.

2) tests are failing with error
Cannot find module '../dist/cjs/handlebars'
Error: Cannot find module '../dist/cjs/handlebars'

Please fix the tests or disable them by filing upstream issue with using tests.

Seems like a bug in nodejs-handlebars, tests did succeed here (with my variant of handlebars)

nodejs-handlebars-2.0.0-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-handlebars-2.0.0-3.fc21

I tried above handlebars update but for me local build still complains same
Cannot find module '../dist/cjs/handlebars'
Error: Cannot find module '../dist/cjs/handlebars'

Ah and after disabling tests in nodejs-istanbul.spec, building it, I got a file name conflict
Error: Transaction check error:
  file /usr/bin/istanbul from install of nodejs-istanbul-0.3.2-1.fc21.noarch conflicts with file from package istanbul-0.2.2-22.fc21.x86_64

Maybe you should install it as istanbul-js

I found packaging issue with nodejs-handlebars and reported in bug 1172471.

Thank you. I was actually looking into it right now, you beat me ;)

updated spec and srpm:
Spec URL: https://piotrp.fedorapeople.org/nodejs-istanbul.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-istanbul-0.3.2-3.fc21.src.rpm


- Renamed binary name to prevent conflict
- Temporary disabled tests because of RHBZ#1172471
- Removed group tag
- Added rm -rf node_modules


Only actually using istanbul gives me the same error as the test because of missing dist dir:


➜  rpmbuild  /usr/bin/istanbul-js 
Cannot find module '../dist/cjs/handlebars'
Error: Cannot find module '../dist/cjs/handlebars'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/usr/lib/node_modules/handlebars/index.js:6:18)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)

Error: Could not register report from file html.js
    at /usr/lib/node_modules/istanbul/lib/util/factory.js:60:27
    at Array.forEach (native)
    at Object.Factory.loadStandard (/usr/lib/node_modules/istanbul/lib/util/factory.js:53:29)
    at Object.<anonymous> (/usr/lib/node_modules/istanbul/lib/register-plugins.js:11:8)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)



Should we wait on https://bugzilla.redhat.com/show_bug.cgi?id=1172471 before approving?

I don't think we need to wait for bug 1172471 and also I need this package badly for some of my upcoming nodejs package reviews.

APPROVED.

New Package SCM Request
=======================
Package Name: nodejs-istanbul
Short Description: A JS code coverage tool written in JS
Upstream URL: https://github.com/gotwarlost/istanbul
Owners: piotrp
Branches: f19 f20 f21 el6 epel7

Git done (by process-git-requests).

nodejs-istanbul-0.3.2-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-istanbul-0.3.2-3.fc21

nodejs-istanbul-0.3.2-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-istanbul-0.3.2-3.fc20

nodejs-istanbul-0.3.2-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nodejs-istanbul-0.3.2-3.fc19

nodejs-istanbul-0.3.2-3.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-istanbul-0.3.2-3.el7

nodejs-istanbul-0.3.2-3.el7 has been pushed to the Fedora EPEL 7 testing repository.

nodejs-istanbul-0.3.2-3.fc20 has been pushed to the Fedora 20 stable repository.

nodejs-istanbul-0.3.2-3.fc21 has been pushed to the Fedora 21 stable repository.

nodejs-istanbul-0.3.2-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.