Bug 1171341
| Summary: | Review Request: nodejs-dot-case - Dot case a string | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Piotr Popieluch <piotr1212> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-dot-case-1.0.1-1.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-27 00:56:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1171302 | ||
| Bug Blocks: | 1171350 | ||
|
Description
Piotr Popieluch
2014-12-05 22:36:20 UTC
Please add following to all packages where you are using mocha in %check BuildRequires: npm(mocha) All such packages are failing to build in mock. I have done below review by adding above Review: + Package built successful in mock (f22 x86_64) + rpmlint on generated rpms gave output nodejs-dot-case.noarch: W: only-non-binary-in-usr-lib nodejs-dot-case.noarch: W: dangling-symlink /usr/lib/node_modules/dot-case/node_modules/sentence-case /usr/lib/node_modules/sentence-case 2 packages and 0 specfiles checked; 0 errors, 2 warnings. + Source verified with upstream as (sha256sum) srpm tarball: 15bea0bbba49ecb65e6ee7acdf7a74743034cea13f9023cf7e4c1d9f386f2e82 upstream tarball: 15bea0bbba49ecb65e6ee7acdf7a74743034cea13f9023cf7e4c1d9f386f2e82 + License is "MIT" and included in its own LICENSE file. + follows nodejs packaging guidelines. Suggestions: 1) Add BR: npm(mocha) to succeed mock build 2) rm -rf node_modules in %prep Please provide updated package and I will approve. Hi Parag, thank you again for review. I've updated all nodejs-*case packages to include BR mocha. They now all build in mock. I have not bumped versions. APPROVED. New Package SCM Request ======================= Package Name: nodejs-dot-case Short Description: Dot case a string Upstream URL: https://github.com/blakeembrey/dot-case Owners: piotrp Branches: f20 f21 el6 epel7 Git done (by process-git-requests). nodejs-dot-case-1.0.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-dot-case-1.0.1-1.fc20 nodejs-dot-case-1.0.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-dot-case-1.0.1-1.fc21 nodejs-dot-case-1.0.1-1.fc21 has been pushed to the Fedora 21 testing repository. package built, closing. nodejs-dot-case-1.0.1-1.fc20 has been pushed to the Fedora 20 stable repository. nodejs-dot-case-1.0.1-1.fc21 has been pushed to the Fedora 21 stable repository. nodejs-dot-case-1.0.1-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-dot-case-1.0.1-1.el7 nodejs-dot-case-1.0.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. |