Bug 1171420

Summary: powerline-1.3-2 not built with $RPM_OPT_FLAGS
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: powerlineAssignee: Andreas Schneider <asn>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: asn
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: powerline-1.3.1-2.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-01-03 19:01:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 496968    
Attachments:
Description Flags
Honor $RPM_OPT_FLAGS none

Description Ville Skyttä 2014-12-06 18:51:49 UTC
Created attachment 965447 [details]
Honor $RPM_OPT_FLAGS

'git am'able fix attached.

Comment 1 Andreas Schneider 2014-12-08 17:22:30 UTC
Have you committed the fix upstream? I'm not sure this the correct way to fix this. It should honour CFLAGS cause they also work on Arch Linux, Gentoo, Debian and other Linux distributions.

I do not want to maintain Red Hat only patches which are not acceptable upstream. Does this make sense? Can you open a bug upstream?

Comment 2 Ville Skyttä 2014-12-08 20:53:13 UTC
I don't have commit access upstream, nor do I have anything to do with powerline in general (not even a user), therefore I haven't submitted anything upstream either. It does make sense to submit patches upstream, sure. I suggest you as the package maintainer take care of that the way you see fit -- it might take a bit more than something like the ugly hack that is my patch and if I'd have time for a proper upstream patch I would have already done it...

Comment 3 Fedora Update System 2014-12-11 15:07:35 UTC
powerline-1.3.1-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/powerline-1.3.1-2.fc21

Comment 4 Fedora Update System 2014-12-11 16:04:45 UTC
powerline-1.3.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/powerline-1.3.1-2.fc20

Comment 5 Fedora Update System 2014-12-13 09:38:58 UTC
Package powerline-1.3.1-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing powerline-1.3.1-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-16821/powerline-1.3.1-2.fc20
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2015-01-03 19:01:51 UTC
powerline-1.3.1-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2015-01-03 19:07:08 UTC
powerline-1.3.1-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.