Bug 1171898
| Summary: | maven_depmap.py: Generate ownership on mavenpomdir subdirectories | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | javapackages-tools | Assignee: | Mikolaj Izdebski <mizdebsk> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mat.booth, mizdebsk, msimacek, msrb |
| Target Milestone: | --- | Keywords: | FutureFeature, Upstream, VerifiedUpstream |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 4.5.0-1 | Doc Type: | Enhancement |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-04-09 08:54:22 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Orion Poplawski
2014-12-08 21:21:08 UTC
Generated .mfiles: %attr(0644,root,root) /usr/share/maven-metadata/sonatype-oss-parent.xml %attr(0644,root,root) /usr/share/maven-poms/sonatype-oss-parent/oss-parent.pom need a: %dir /usr/share/maven-poms/sonatype-oss-parent not sure the %attr() is really necessary. Without it you could just do: /usr/share/maven-poms/sonatype-oss-parent/ I will consider this for next javapackages release. I think this may be just a misunderstanding. maven_depmap.py is only used from within %add_maven_depmap macro, i.e. it's only being called on already manually installed artifacts. Since package maintainer had to manually create the subdirectories, I think it's up to him/her to decide which (sub)packages should own them. maven_depmap.py doesn't have enough information to make the decision. (In reply to Orion Poplawski from comment #0) > > file /usr/share/maven-poms/slf4j is not owned by any package > file /usr/share/maven-poms/sonatype-oss-parent is not owned by any package > file /usr/share/maven-poms/spice-parent is not owned by any package > I looked and it seems that none of these packages call maven_depmap.py. All of them use %mvn_install, which means that xmvn-install is responsible for generating .mfiles in this case. This looks like a bug in XMvn and it should be addressed there, if possible. Whoever generates the .mfiles list has the info and should generate the proper ownership. The guidelines indicate that using .mfiles is all that is necessary. I'll try to make this feature available in Fedora 22, but I need to clear some things with FPC first. Implemented upstream. This will be available in F23+ Verified upstream using javapackages-tools-4.5.0-0.39.git6d94451 Now %dir directives are generated for every subdirectory of javadir, jnidir or mavenpomdir. I believe that this feature is included in javapackages-tools-4.5.0-1, which is available in Fedora Rawhide, so I am closing this bug now. The build which includes the feature can be found at Koji: http://koji.fedoraproject.org/koji/buildinfo?buildID=627008 Looks good, thanks! |