Bug 117219

Created attachment 98167 [details]
Comparison of block size with O_DIRECT use vs normal CP operation

Comparison of block size with O_DIRECT use vs normal copy (cp) operation.

With O_DIRECT we get a 220% speed boost.
additional testing on an ext2/3 FS shows that there is a speed improvement of
~15-40% depending on system jobs running.

erm that was unexpected. ok I'm gonna regenerate the patchkit, might
be a wee while... appologies

Phil
=--=

Created attachment 98197 [details]
O_DIRECT patchs for coreutils-4.5.3-26

This is a set of patchs to provide at LEAST the capability f working when
O_DIRECT is required,..  Note: only cp/mv are actually optimized, the rest are
just tweaked to handle the use of O_DIRECT


tar patchs to follow

Cheers

Phil (aka Bryce)
=--=

Created attachment 98199 [details]
O_DIRECT patchs to tar-1.3.25-13 (AS3)

These patchs add the --o_direct option to tar

Cheers

Phil (aka Bryce)
=--=

Thanks.  Please submit new patches, with these things fixed:

o There are a huge number of do-nothing changes, like this:

-  char const* name;
+  char const *name;

  If these are due to files being copied from newer upstream versions,
I would much prefer the patch against the newer upstream version. 
Either way, they make the patch unreadable for the clutter.

o Some #include additions seem not to be needed: 'linux/fs.h', for
instance, seems to be pulled in for no reason in some places.

o Jim Meyering has complained to be before about us including patches
with such things as:

+static void
+parse_o_direct (char *str)
+{
+  if (strstr (str, "yes") != NULL)
+    o_direct_option = 1;
+  if (strstr (str, "y") != NULL)
+    o_direct_option = 1;
+
+  if ((o_direct_option == 0) && (basename(program_name) == ALT_ALIAS))
+    o_direct_option = 1;
+
+  if ((basename(program_name) == ALT_ALIAS) &&
+     ((strstr (str, "n") != NULL) ||
+     (strstr (str, "no") != NULL)))
+    o_direct_option = 0;
+}

The use of strstr here is not really appropriate -- I would expect
'o_direct=yesn' to give an error.  XARGMATCH is written for this purpose.

o Please make sure to update the man pages and info pages with the
additional options.

Unfortunately noone seems to tidy up their src afterwards through
indent -gnu  which is probably where the " *" -> "* " translations
came from but remember I forward ported that from fileutils from AS2.1
so some of that is expected (if annoying)

The man Pages are updated (in that they are automatically regenerated
 by running <progname> and dumping out the --help text (which is
bizzare but thats how they do it)

I'll check on the info pages

XARGMATCH huh? thats new to me, I'll go have a look at it.


I'm assuming this is a formal rejection of the patchs then. It'll be a
few days before I can rebuild it all in a manner more to your pleasing
(remember I originally built it all as an inhouse change not really
for upstream use)

cheers

Phil
=--=

This bug is filed against RHEL 3, which is in maintenance phase.
During the maintenance phase, only security errata and select mission
critical bug fixes will be released for enterprise products. Since
this bug does not meet that criteria, it is now being closed.
 
For more information of the RHEL errata support policy, please visit:
http://www.redhat.com/security/updates/errata/
 
If you feel this bug is indeed mission critical, please contact your
support representative. You may be asked to provide detailed
information on how this bug is affecting you.