Bug 1172548
Summary: | oo-last-access does not accept gear uuid when USE_PREDICTABLE_GEAR_UUIDS="true" | ||
---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Gaoyun Pei <gpei> |
Component: | Containers | Assignee: | Luke Meyer <lmeyer> |
Status: | CLOSED ERRATA | QA Contact: | libra bugs <libra-bugs> |
Severity: | high | Docs Contact: | |
Priority: | high | ||
Version: | 2.2.0 | CC: | bleanhar, jokerman, libra-onpremise-devel, mmccomas |
Target Milestone: | --- | Keywords: | Upstream |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | openshift-origin-node-util-1.34.0.1-1 | Doc Type: | Bug Fix |
Doc Text: |
Cause:
oo-last-access created a table of known gears to assess by looking for entries in /var/lib/openshift that looked like gear UUIDs. Gears with UUIDs created with USE_PREDICTABLE_GEAR_UUIDS="true" were not being added to the table and therefore their log entries were not counted.
Consequence:
The idler would count these gears as idle despite recent activity and stop them.
Fix:
The logic for populating the table of gears was fixed to include all gears.
Result:
Web access should prevent gears from idling as intended.
|
Story Points: | --- |
Clone Of: | Environment: | ||
Last Closed: | 2015-02-12 13:09:47 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Gaoyun Pei
2014-12-10 11:02:00 UTC
The interesting thing is oo-last-access could work on a node which is using vhost. Seems `add_alias_data` in /usr/sbin/oo-last-access helps to find correct gear uuid by chance. Checking whether the dir fits a regex strikes me as a bad way to determine whether it's a gear. Especially now that the gear UUID could be almost anything. Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/dd28b1706b9ce6affc89bb429935cc57b7a4cca3 oo-last-access: fix gear UUID detection oo-last-access previously created a table of known gears by looking for entries in /var/lib/openshift that looked like gear UUIDs. Now that UUIDs can look different, some were not being added to the table. This commit updates the logic to include all gears. Bug 1172548 - oo-last-access does not accept gear uuid when USE_PREDICTABLE_GEAR_UUIDS="true" https://bugzilla.redhat.com/show_bug.cgi?id=1172548 Verify the bug with openshift-origin-node-util-1.34.0.1-1 1. Make sure broker has enabled USE_PREDICTABLE_GEAR_UUIDS=TRUE in broker.conf. Create an app. Visit the app. The access log was recorded in /var/log/httpd/openshift_log on the node: [root@node2 ~]# tailf /var/log/httpd/openshift_log 10.**.**.** app1-123.ose22-manual.com.cn - - [26/Jan/2015:10:33:07 +0800] "GET / HTTP/1.1" 200 39627 "-" "curl/7.19.7 (x86_64-redhat-linux-gnu) libcurl/7.19.7 NSS/3.16.2.3 Basic ECC zlib/1.2.3 libidn/1.18 libssh2/1.4.2" (3856us) - 127.3.223.1:8080/ 54c5a694e5fed513c6000009 123-app1-1 2. Run 'oo-last-access' on the node. [root@node2 ~]# oo-last-access [root@node2 .last_access]# cat 123-app1-1 26/Jan/2015:10:33:07 +0800 This is working fine on both vhost and mod-rewrite frontend. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-0220.html |