Bug 1172646
| Summary: | Provide an annotation driven way of declaring protobuf metadata | |||
|---|---|---|---|---|
| Product: | [JBoss] JBoss Data Grid 6 | Reporter: | Tristan Tarrant <ttarrant> | |
| Component: | Infinispan | Assignee: | Adrian Nistor <anistor> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Martin Gencur <mgencur> | |
| Severity: | unspecified | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 6.4.0 | CC: | dmehra, dstahl, jdg-bugs, mgencur | |
| Target Milestone: | CR1 | |||
| Target Release: | 6.4.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1182112 (view as bug list) | Environment: | ||
| Last Closed: | 2015-01-28 13:26:35 UTC | Type: | Enhancement | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1153111, 1182112 | |||
|
Description
Tristan Tarrant
2014-12-10 13:53:01 UTC
Was trying to run RemoteCacheOSGiIT after applying https://github.com/infinispan/jdg/pull/418 but ended up with the following exceptions: testAttributeQuery(org.infinispan.server.test.client.hotrod.osgi.RemoteCacheOsgiIT) Time elapsed: 0.09 sec <<< ERROR! org.infinispan.protostream.annotations.ProtoSchemaBuilderException: Class org.infinispan.protostream.sampledomain.User does not have any @ProtoField annotated fields. at org.infinispan.protostream.annotations.impl.ProtoMessageTypeMetadata.scanMemberAnnotations(ProtoMessageTypeMetadata.java:169) at org.infinispan.protostream.annotations.impl.ProtoSchemaGenerator.generateAndRegister(ProtoSchemaGenerator.java:59) at org.infinispan.protostream.annotations.ProtoSchemaBuilder.build(ProtoSchemaBuilder.java:64) at org.infinispan.server.test.client.hotrod.osgi.RemoteCacheOsgiIT.testAttributeQuery(RemoteCacheOsgiIT.java:130) Then I removed references to User and re-ran the test, I got this: testAttributeQuery(org.infinispan.server.test.client.hotrod.osgi.RemoteCacheOsgiIT) Time elapsed: 0.102 sec <<< ERROR! org.infinispan.protostream.annotations.ProtoSchemaBuilderException: Non-public fields cannot be @ProtoField annotated: private java.lang.String org.infinispan.protostream.sampledomain.Note.text at org.infinispan.protostream.annotations.impl.ProtoMessageTypeMetadata.discoverFields(ProtoMessageTypeMetadata.java:203) at org.infinispan.protostream.annotations.impl.ProtoMessageTypeMetadata.scanMemberAnnotations(ProtoMessageTypeMetadata.java:167) at org.infinispan.protostream.annotations.impl.ProtoSchemaGenerator.generateAndRegister(ProtoSchemaGenerator.java:59) at org.infinispan.protostream.annotations.ProtoSchemaBuilder.build(ProtoSchemaBuilder.java:64) at org.infinispan.server.test.client.hotrod.osgi.RemoteCacheOsgiIT.testAttributeQuery(RemoteCacheOsgiIT.java:130) Returning this BZ back to ASSIGNED. Adrian saw the exceptions too and is looking into it. Looks like this needs a bit more polishing. The fix is being reviewed upstream: https://github.com/infinispan/infinispan/pull/3189 I'll backport it ASAP once it is integrated upstream. changes are implemented by https://bugzilla.redhat.com/show_bug.cgi?id=1180473 The tests now run fine with standalone JDG as well as in OSGi. This is actually an enhancement and does not have to be documented in release notes. I suppose this is documented in the main documentation. Clarification: I meant it does not have to be in release notes under "Resolved issues". We might still want to mention the enhancement in a different section. Is this enhancement documented under the Remote Querying section of the Infinispan Query guide ? No Divya, I've just taken a look and found out this is not documented in the query guide. |