Bug 1172693

Summary: Zombie bash processes left after closing gnome-terminal
Product: [Fedora] Fedora Reporter: Tuomas Kuosmanen <tigert>
Component: vte291Assignee: Kalev Lember <kalevlember>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 21CC: debarshir, egmont, kalevlember, mclasen, trevor, zeenix
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-01-06 17:49:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tuomas Kuosmanen 2014-12-10 14:59:43 UTC
Description of problem: Bash processes are left as zombies when I close the gnome-terminal window from the close-button (x).

Version-Release number of selected component (if applicable):
gnome-terminal-3.14.2-1.fc21.x86_64

How reproducible: Always

Steps to Reproduce:
1. Open two gnome-terminal windows. Close other from window-manager controls 
   (close-button)
2. run "ps auxw | grep bash" on the other
3. Observe zombie bash process is left hanging in the process table:

   tigert   10577  0.0  0.0      0     0 ?        Zs   16:50   0:00 [bash <defunct>

This is cleared out when the last open gnome-terminal window is closed.

For the record, if the shell is closed with ctrl-d, the problem does not occur.

Comment 1 Egmont Koblinger 2014-12-10 18:30:12 UTC
This is already fixed in mainstream git. See

https://bugzilla.gnome.org/show_bug.cgi?id=740929

https://git.gnome.org/browse/vte/commit/?h=vte-0-38&id=d9d83d4
https://git.gnome.org/browse/vte/commit/?h=vte-0-38&id=b033047

Fedora should probably backport this to F21.

Comment 2 Debarshi Ray 2015-01-06 17:49:58 UTC
Should be fixed in vte291-0.38.2-3.fc21 which is available as a stable update.

Comment 3 Egmont Koblinger 2015-01-06 19:57:48 UTC
Debarshi: Wait... the updated package only contains my first buggy patch; your followup patch to completely fix it is missing.

I can't see if it only causes critical warnings, or actually something bad could happen.

Comment 4 Debarshi Ray 2015-01-07 12:36:00 UTC
(In reply to Egmont Koblinger from comment #3)
> Debarshi: Wait... the updated package only contains my first buggy patch;
> your followup patch to completely fix it is missing.
> 
> I can't see if it only causes critical warnings, or actually something bad
> could happen.

g_child_watch_add_full starts with this guard:
g_return_val_if_fail (pid > 0, 0);

Therefore, nothing bad should happen, apart from the CRITICAL. I did not want to bother users with another update just to silence the CRITICAL.