Bug 1172833

open-vm-tools version 9.10.0 brings two new configurations, cert generation for guestProxy plugin using guestproxycerttool and starting/stopping/restarting vgauth service along with vmtoolsd.

Please refer Fedora 22 update that we have done under bug https://bugzilla.redhat.com/show_bug.cgi?id=1217864.

FYI, here are the git commits for Fedora 22:

1. http://pkgs.fedoraproject.org/cgit/open-vm-tools.git/commit/?id=c5619c1d060930b2c6c85d1c16c9f02f5a388a74
2. http://pkgs.fedoraproject.org/cgit/open-vm-tools.git/commit/?id=8df2fd7cf73cc14d44d5784c510ee6937e9f786c

Please note that two BuildRequires are not available in RHEL 7:

* libmspack-devel
* xml-security-c-devel

When building for RHEL I removed both dependencies.  This means
"deploypkg" and "vgauth" functionality is not available, if that
matters.  RHEL 7 has "xml-security".  I don't know if that would
be a suitable replacement for "xml-security-c" or not.

Here is the package for you to test.  Let me know how it goes.

http://oirase.annexia.org/tmp/bz1172833-open-vm-tools-rebase/

My customer wants an updated package containing "deploypkg"
Not having it defeats the purpose of the update for them.

Regards
Stuart

(In reply to Richard W.M. Jones from comment #4)
> Please note that two BuildRequires are not available in RHEL 7:
> 
> * libmspack-devel
> * xml-security-c-devel
> 
> When building for RHEL I removed both dependencies.  This means
> "deploypkg" and "vgauth" functionality is not available, if that
> matters.  RHEL 7 has "xml-security".  I don't know if that would
> be a suitable replacement for "xml-security-c" or not.

Yes, these are significant parts of new functionality in open-vm-tools. "deployPkg" is must for guest customization and "vgauth" is must for SAML token based authentication. We need to do get necessary stuff to enable these. I see that Stuart submitted a request to package libmspack already. Please advise on any other steps we need to do to get these components enabled.

If we need vgauth as well, then another new package (xml-security-c)
will have to be added.  As before, please add a new bug against the
product "Red Hat Enterprise Linux 7", component "distribution", and
make this bug depend on it.

(In reply to Richard W.M. Jones from comment #8)
> If we need vgauth as well, then another new package (xml-security-c)
> will have to be added.  As before, please add a new bug against the
> product "Red Hat Enterprise Linux 7", component "distribution", and
> make this bug depend on it.

Submitted bug 1223559.

It is not blocked by bug bug 1172335, instead it is other way around.

Richard, we have got a serious functionality issue with open-vm-tools upgrade from 9.4.x to 9.10.0 in guests running on ESXi 5.5.x hosts. We are working on getting a fix out in open-vm-tools as soon as possible. In the meantime, could you please hold the work for this bug?

Please refer https://github.com/vmware/open-vm-tools/issues/16 for details.

(In reply to Ravindra Kumar from comment #11)
> Richard, we have got a serious functionality issue with open-vm-tools
> upgrade from 9.4.x to 9.10.0 in guests running on ESXi 5.5.x hosts. We are
> working on getting a fix out in open-vm-tools as soon as possible. In the
> meantime, could you please hold the work for this bug?
> 
> Please refer https://github.com/vmware/open-vm-tools/issues/16 for details.

Noted.  We've still got a month or two of development time, so
we can either add a fix or pull the rebase in that time.

Do we have an update on the status of a fix for the issue mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=1172833#c11 ?

Hi John,

The issue has been fixed in open-vm-tools 9.10.2 release. It can be picked up here: 
https://github.com/vmware/open-vm-tools/tree/stable-9.10.2

Thanks,
Yogi

The downloadable tarball can be picked from, http://sourceforge.net/projects/open-vm-tools/files/open-vm-tools/stable-9.10.x/open-vm-tools-9.10.2-2822639.tar.gz.

Announcement message, https://sourceforge.net/p/open-vm-tools/mailman/message/34272954/.

Ravindra, I'd prefer if Fedora (Rawhide) was updated with this
package, and then I can just pull your change into RHEL 7.2.

Ok, I will do it asap. I will let you know once I'm done.

Rawhide change, http://pkgs.fedoraproject.org/cgit/open-vm-tools.git/commit/?id=3525cce0f90a180aaabff90bd9cce44572f1290e.

FYI, I will be using bug 1240813 for this.

Ravindra, can you verify these changes are correct:

open-vm-tools-devel

  changed from Provides: pkgconfig(vmguestlib) = 2015.01.29 to Provides: pkgconfig(vmguestlib) = 9.10.2 on x86_64

open-vm-tools

  1 file shrank significantly on x86_64: /usr/share/doc/open-vm-tools-9.10.{0|2}/ChangeLog: from 183780 to 6424 bytes (-96%)

(In reply to Richard W.M. Jones from comment #22)
> Ravindra, can you verify these changes are correct:
> 
> open-vm-tools-devel
> 
>   changed from Provides: pkgconfig(vmguestlib) = 2015.01.29 to Provides:
> pkgconfig(vmguestlib) = 9.10.2 on x86_64

This is correct. Old one was incorrect.

> open-vm-tools
> 
>   1 file shrank significantly on x86_64:
> /usr/share/doc/open-vm-tools-9.10.{0|2}/ChangeLog: from 183780 to 6424 bytes
> (-96%)

This is an issue in the ChangeLog file. Looks like, our developer removed the old entries.

The package is now on QA.  Ravindra, please grab the package
from here:

https://people.redhat.com/~rjones/open-vm-tools-rhel-7.2-preview/

and check everything works.  If there are any problems found, you
can follow up in this BZ (or I guess file new BZs if the problems
are particularly serious).

Thanks Richard for the quick turn around. There are few problems with this package:

$ rpm -qlp open-vm-tools-9.10.2-1.el7.x86_64.rpm | grep "bin\|plugins"
/usr/bin/vm-support
/usr/bin/vmtoolsd
/usr/bin/vmware-checkvm
/usr/bin/vmware-guestproxycerttool
/usr/bin/vmware-hgfsclient
/usr/bin/vmware-rpctool
/usr/bin/vmware-toolbox-cmd
/usr/bin/vmware-xferlogs
/usr/lib64/open-vm-tools/plugins
/usr/lib64/open-vm-tools/plugins/common
/usr/lib64/open-vm-tools/plugins/common/libhgfsServer.so
/usr/lib64/open-vm-tools/plugins/common/libvix.so
/usr/lib64/open-vm-tools/plugins/vmsvc
/usr/lib64/open-vm-tools/plugins/vmsvc/libgrabbitmqProxy.so
/usr/lib64/open-vm-tools/plugins/vmsvc/libguestInfo.so
/usr/lib64/open-vm-tools/plugins/vmsvc/libpowerOps.so
/usr/lib64/open-vm-tools/plugins/vmsvc/libtimeSync.so
/usr/lib64/open-vm-tools/plugins/vmsvc/libvmbackup.so

Following 3 files are missing:
/usr/bin/VGAuthService
/usr/bin/vmware-vgauth-cmd
/usr/lib64/open-vm-tools/plugins/vmsvc/libdeployPkgPlugin.so

These files belong to two main new features in this release. Any idea how to get these included?

Those are the features that depend on libmspack and xml-security-c?

There are bugs filed for those packages:
libmspack: https://bugzilla.redhat.com/show_bug.cgi?id=1223486
xml-security-c: https://bugzilla.redhat.com/show_bug.cgi?id=1223559
but it seems unlikely we'll get them for RHEL 7, especially
xml-security-c because it's a huge dependency.

(In reply to Richard W.M. Jones from comment #26)
> Those are the features that depend on libmspack and xml-security-c?

libdeployPkgPlugin depends on libmspack and VGAuthService depends on xml-security-c. 

> There are bugs filed for those packages:
> libmspack: https://bugzilla.redhat.com/show_bug.cgi?id=1223486
> xml-security-c: https://bugzilla.redhat.com/show_bug.cgi?id=1223559
> but it seems unlikely we'll get them for RHEL 7, especially
> xml-security-c because it's a huge dependency.

You are considering it huge because of its size or number of its own dependencies?

I'm not actually the one who gets to decide these things, but
it was seen as a problem that xml-security-c adds about 500K lines
of C++ code (when you include the dependency, xalan-c).  You may
wish to talk to your management-level contacts at Red Hat.

Anyway, can you review the package without these modules and
if we get the dependencies added, I can build a new open-vm-tools
package later.

The packages look fine except following two differences:

1. open-vm-tools-9.10.2-1.el7.x86_64.rpm package is using /usr/share/doc/open-vm-tools-9.10.2/ path instead of /usr/share/doc/open-vm-tools/ for the files below,

  /usr/share/doc/open-vm-tools-9.10.2/AUTHORS
  /usr/share/doc/open-vm-tools-9.10.2/ChangeLog
  /usr/share/doc/open-vm-tools-9.10.2/COPYING
  /usr/share/doc/open-vm-tools-9.10.2/NEWS
  /usr/share/doc/open-vm-tools-9.10.2/README

2. open-vm-tools-devel-9.10.2-1.el7.x86_64.rpm package is using /usr/share/doc/open-vm-tools-devel-9.10.2/ instead of /usr/share/doc/open-vm-tools-devel/ path for storing documentation persistently.

Not sure if these differences are intentional or a mistake.

(In reply to Ravindra Kumar from comment #27)
> libdeployPkgPlugin depends on libmspack and VGAuthService depends on
> xml-security-c. 
> 
Including libdeployPkgPlugin and libmspack (bug 1223486) is a higher priority for us. Please try to include in 7.2. This plugin is newly open sourced with v9.10, but the functionality has existed for a long time. In the past for RHEL 7.0/7.1, we provided the plugin as a separately installed binary here > http://packages.vmware.com/packages/rhel7/x86_64/index.html which is not required any more since it is open source. This plugin is required to customize VM templates and for some data center fail-over operations. This is VMware's method of doing cloud-init.

It is also desirable to include VGAuthService and xml-security-c (bug 1223559) in soonest 7.x release possible.

Thanks,
John

(In reply to Ravindra Kumar from comment #29)
> The packages look fine except following two differences:
> 
> 1. open-vm-tools-9.10.2-1.el7.x86_64.rpm package is using
> /usr/share/doc/open-vm-tools-9.10.2/ path instead of
> /usr/share/doc/open-vm-tools/ for the files below,
> 
>   /usr/share/doc/open-vm-tools-9.10.2/AUTHORS
>   /usr/share/doc/open-vm-tools-9.10.2/ChangeLog
>   /usr/share/doc/open-vm-tools-9.10.2/COPYING
>   /usr/share/doc/open-vm-tools-9.10.2/NEWS
>   /usr/share/doc/open-vm-tools-9.10.2/README
> 
> 2. open-vm-tools-devel-9.10.2-1.el7.x86_64.rpm package is using
> /usr/share/doc/open-vm-tools-devel-9.10.2/ instead of
> /usr/share/doc/open-vm-tools-devel/ path for storing documentation
> persistently.
> 
> Not sure if these differences are intentional or a mistake.

I believe this change is caused by this feature of Fedora 20:
https://fedoraproject.org/wiki/Changes/UnversionedDocdirs

Since RHEL 7 was branched from Fedora 18 (or 19?) we don't have
that change in RHEL yet, so these paths are OK.

Verified the bug.

The bug related host version:Hyper-V server 2012R2

The bug related guest version:rhel7 3.10.0-295.el7.x86_64

Steps to Reproduce:
1.Install a guest rhel7.2 and select the server with GUI.
2.Search the open-vm-tools with command:yum info open-vm-tools.

The open-vm-tools version is open-vm-tools-9.10.2-1.el7.x86_64, The test result: Verified.

so(In reply to ldu from comment #32)
> Verified the bug.
> 
> The bug related host version:Hyper-V server 2012R2
> 
> The bug related guest version:rhel7 3.10.0-295.el7.x86_64
> 
> Steps to Reproduce:
> 1.Install a guest rhel7.2 and select the server with GUI.
> 2.Search the open-vm-tools with command:yum info open-vm-tools.
> 
> The open-vm-tools version is open-vm-tools-9.10.2-1.el7.x86_64, The test
> result: Verified.

sorry to make a mistake about the host version is wrong,the actual host is "ESXi 5.5U2".

Testing open-vm-tools-9.10.2-1.el7.x86_64.rpm shows the vmtoolsd.service unit file depends on the vgauthd.service unit which isn't in the RPM due to the excluded features.

# sudo systemctl restart vmtoolsd
Failed to issue method call: Unit vgauthd.service failed to load: No such file or directory.

Removing the references to vgauthd from the vmtoolsd.service allows the service to be started successfully.

(In reply to Adam Stephens from comment #34)
> Testing open-vm-tools-9.10.2-1.el7.x86_64.rpm shows the vmtoolsd.service
> unit file depends on the vgauthd.service unit which isn't in the RPM due to
> the excluded features.
> 
> # sudo systemctl restart vmtoolsd
> Failed to issue method call: Unit vgauthd.service failed to load: No such
> file or directory.
> 
> Removing the references to vgauthd from the vmtoolsd.service allows the
> service to be started successfully.

I also meet this problem, and I had reply in Bug 1223559,  Richard W.M. Jones had work on this.

Updated packages available:

https://people.redhat.com/~rjones/open-vm-tools-rhel-7.2-preview/

* Mon Jul 27 2015 Richard W.M. Jones <rjones> - 9.10.2-2
- Disable vgauthd service in vmtoolsd.service file.
  resolves: rhbz#1172833

Moving back to ON_QA since it clearly wasn't verified before if the
service couldn't be started up in the guest.

Hi Richard,

Test with the build open-vm-tools-9.10.2-2.el7.x86_64.rpm, the vmtoolsd.service can start, restart normal,this build had fix the issue.

Verified the bug.

The bug related host version:ESXi 6.0
The bug related guest version:rhel7 3.10.0-302.el7.x86_64
The open-vm-tools version:open-vm-tools-9.10.2-3.el7


Do some sanity test on this open-vm-toos version, the open-vm-tools works well.
 
The test result: Verified.

(In reply to Richard W.M. Jones from comment #36)
> Updated packages available:
> 
> https://people.redhat.com/~rjones/open-vm-tools-rhel-7.2-preview/
> 
> * Mon Jul 27 2015 Richard W.M. Jones <rjones> - 9.10.2-2
> - Disable vgauthd service in vmtoolsd.service file.
>   resolves: rhbz#1172833

Filed RH bug 1269243 to track re-enabling this service in 7.3.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2246.html

*** Bug 2189622 has been marked as a duplicate of this bug. ***

*** Bug 2189941 has been marked as a duplicate of this bug. ***