Bug 1173336
Summary: | Duplicate vm names when multiple soap requests are issued | ||
---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | Josh Carter <jocarter> |
Component: | Automate | Assignee: | Bill Wei <bilwei> |
Status: | CLOSED ERRATA | QA Contact: | Milan Falešník <mfalesni> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 5.3.0 | CC: | bilwei, mfeifer, ssainkar |
Target Milestone: | GA | ||
Target Release: | 5.4.0 | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Fixed In Version: | 5.4.0.0.11 | Doc Type: | Bug Fix |
Doc Text: |
In the previous version of CloudForms Management Engine, during VM provisioning, if the VM name was defined to use enumeration as part of the naming, the get_vm_full_name method was called in /app/models/miq_provision/naming.rb. This method can be called from multiple processes (across multiple appliance) at the same time and in a race condition resulted in the same enumeration value being returned. As a result, duplicate VM names were issued with multiple soap requests during provisioning.
This bug has been fixed by implementing store next naming sequence in custom_attributes. Thus, naming sequences are global through current region.
|
Story Points: | --- |
Clone Of: | Environment: | ||
Last Closed: | 2015-06-16 12:46:22 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Comment 2
Greg McCullough
2015-01-13 14:52:03 UTC
New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/d2689d3c182475861973885bfaf5f74b7d484205 commit d2689d3c182475861973885bfaf5f74b7d484205 Author: Bill Wei <bilwei> AuthorDate: Thu Jan 15 11:59:49 2015 -0500 Commit: Bill Wei <bilwei> CommitDate: Thu Jan 29 10:29:15 2015 -0500 Store next naming sequence in custom_attributes With this implemenation naming sequences are global through current region. The binding can be changed to other models through NamingSequenceMixin. https://bugzilla.redhat.com/show_bug.cgi?id=1173336 vmdb/app/models/miq_provision/naming.rb | 28 ++++++++----------------- vmdb/app/models/miq_region.rb | 2 +- vmdb/app/models/mixins/naming_sequence_mixin.rb | 17 +++++++++++++++ vmdb/spec/models/miq_provision_spec.rb | 18 ++++++++++++++++ vmdb/spec/models/miq_region_spec.rb | 7 +++++++ 5 files changed, 52 insertions(+), 20 deletions(-) create mode 100644 vmdb/app/models/mixins/naming_sequence_mixin.rb New commit detected on cfme/5.3.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=5442dc86ed9692c16b8719bbeefdb3fbd4900902 commit 5442dc86ed9692c16b8719bbeefdb3fbd4900902 Author: Bill Wei <bilwei> AuthorDate: Thu Jan 15 11:59:49 2015 -0500 Commit: Bill Wei <bilwei> CommitDate: Mon Feb 23 10:23:29 2015 -0500 Store next naming sequence in custom_attributes With this implemenation naming sequences are global through current region. The binding can be changed to other models through NamingSequenceMixin. https://bugzilla.redhat.com/show_bug.cgi?id=1173336 https://bugzilla.redhat.com/show_bug.cgi?id=1194319 Conflicts: vmdb/app/models/miq_provision/naming.rb vmdb/app/models/miq_provision/naming.rb | 28 ++++++++----------------- vmdb/app/models/miq_region.rb | 2 +- vmdb/app/models/mixins/naming_sequence_mixin.rb | 17 +++++++++++++++ vmdb/spec/models/miq_provision_spec.rb | 18 ++++++++++++++++ vmdb/spec/models/miq_region_spec.rb | 7 +++++++ 5 files changed, 52 insertions(+), 20 deletions(-) create mode 100644 vmdb/app/models/mixins/naming_sequence_mixin.rb Ok, verified then on 5.4.0.1, it appears to be working. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-1100.html |