Bug 1173346

Summary: Allow to modify arbitrary corosync.conf value
Product: Red Hat Enterprise Linux 7 Reporter: Jan Pokorný [poki] <jpokorny>
Component: pcsAssignee: Tomas Jelinek <tojeline>
Status: CLOSED DUPLICATE QA Contact: cluster-qe <cluster-qe>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 7.1CC: bruno.travouillon, cfeist, cluster-maint, pzimek, sbradley, tojeline
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-09-17 11:43:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jan Pokorný [poki] 2014-12-11 22:09:03 UTC
It would be beneficial, at least for "static config -> pcs commands"
translation to be able to set arbitrary value in corosync.conf.

Best if implemented in a clever way that would use the knowledge
which sections/options can be sensibly repeated (like uidgid section)
and conversely, which should be treated as singleton values
(vast majority;  in reality, IIRC, when specified more than once,
the last instance wins).

Implementation-wise, this would also simplify changes like [1]
by translating, e.g.,

  --token_coefficient 5

to

  --corosync-set totem.token_coefficient=5

prior to handling.


BTW. the metadata for describing the option meaning could be extracted
from "corosync-schema" change I proposed back then:

  https://github.com/jfriesse/corosync/tree/topic-relax-conf-gen

and I even use the schema in clufter right now(!):

  https://github.com/jnpkrn/clufter/blob/v0.3.0/formats/corosync/corosync.rng



[1] https://github.com/feist/pcs/pull/44/files

Comment 1 Jan Pokorný [poki] 2014-12-11 22:10:22 UTC
Allowing something similar for CMAN-backed Pacemaker cluster is also
an option but not needed for clufter purposes.

Comment 5 Tomas Jelinek 2017-10-02 15:20:41 UTC
Which settings are possible to be changed in runtime:
https://github.com/corosync/corosync/wiki/Config-file-values

Comment 6 Bruno Travouillon 2017-10-02 16:47:10 UTC
Tomas,

It would be great to add nodefile.node.x.name to this list.

Comment 8 Jan Pokorný [poki] 2018-08-14 08:22:01 UTC
Note that some precautions should be taken, such as when logging to
file gets configured: [bug 1615420 comment 2].

This is on top of possible schema-based validation ([comment 0]).

Comment 9 Tomas Jelinek 2020-09-17 11:43:45 UTC
Considering the current RHEL 7 life cycle stage, there will be no fix for RHEL 7.
In RHEL 8 this has been or will be fixed shortly by: bz1667061 bz1667058

*** This bug has been marked as a duplicate of bug 1667061 ***