Bug 1173362

Summary:	Check for existing OSMajor when setting alias
Product:	[Retired] Beaker	Reporter:	Amit Saha <asaha>
Component:	general	Assignee:	Dan Callaghan <dcallagh>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	19	CC:	aigao, asaha, dcallagh, ebaak, linwang
Target Milestone:	19.2	Keywords:	FutureFeature, Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-01-20 03:18:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Amit Saha 2014-12-11 23:20:22 UTC

Description of problem:

Fix for bug 907242 prevented importing distros with osmajor matching an existing alias. However, the reverse is still allowed, but should not be. It  breaks operations in other parts of the server such as in adding a task to the task library.

The fix for this bug will not allow setting an alias which already matches an existing osmajor.


Version-Release number of selected component (if applicable):

19.1


How reproducible:

Always.


Steps to Reproduce:
1. Go to the Admin -> OS Versions page
2. Click on any OSMajor
3. Add an alias which is the same as any other existing OSMajor
4. Alias is successfully set

Actual results:

(4) above.

Expected results:

The fix for this bug will not allow setting an alias which already matches an existing osmajor.

Additional info:

Comment 1 Dan Callaghan 2014-12-12 00:18:29 UTC

The other problem we must fix as part of this is that the form currently accepts empty string and stores that. Clearing the alias should store NULL instead.

Believe it or not, "" is a valid OS major and it even exists in our Beaker installation, so storing "" for the alias will still be a duplicate.

Comment 2 Dan Callaghan 2015-01-07 05:02:29 UTC

http://gerrit.beaker-project.org/3898

Comment 5 Dan Callaghan 2015-01-20 03:18:48 UTC

Beaker 19.2 has been released.