Bug 1173368

Summary: empty string should not be a valid OS major name
Product: [Retired] Beaker Reporter: Dan Callaghan <dcallagh>
Component: generalAssignee: matt jia <mjia>
Status: CLOSED CURRENTRELEASE QA Contact: tools-bugs <tools-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: aigao, asaha, dcallagh, dowang, mjia
Target Milestone: 19.2Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-01-20 03:18:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dan Callaghan 2014-12-12 00:24:26 UTC 
Version-Release number of selected component (if applicable):
19.0

Steps to Reproduce:
Not sure. We have an OS major with name "" in our internal Beaker instance, so it can happen *somehow*. One possible way:
1. beaker-import --family= http://<sometree>
Another possible way:
1. bkr distros-edit-version --name=<somedistroname> ""
(Note that these are destructive operations so be careful if you try to reproduce the problem.)

Actual results:
Beaker creates an OS major whose name is the empty string.

Expected results:
The distro import attempt or renaming attempt should be rejected with a useful error message.

Additional info:
Distro name most likely has the same problem and should be fixed in the same way.
Comment 1 matt jia 2015-01-12 01:20:14 UTC 
On Gerrit:

  http://gerrit.beaker-project.org/#/c/3917/

Cheers, Matt Jia
Comment 5 Dan Callaghan 2015-01-20 03:18:47 UTC 
Beaker 19.2 has been released.