Bug 1173683
| Summary: | Review Request: pg-semver - A semantic version data type for PostgreSQL | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard Marko <rmarko> | ||||
| Component: | Package Review | Assignee: | Pavel Raiskup <praiskup> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | jberan, jmlich, package-review, praiskup, rmarko | ||||
| Target Milestone: | --- | Flags: | praiskup:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | pg-semver-0.5.0-2.fc20 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2015-01-30 04:29:47 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Richard Marko
2014-12-12 16:28:56 UTC
Thanks for packaging. I'll do the review soon, but for now, could we keep the
upstream package name, pg-semver in particular? We tend not to create yet
another packages which looks like it comes from 'postgresql.spec'. And it
is also less confusing for new users.
Also, could you please use module-guard require like (rawhide):
postgresql-server(:MODULE_COMPAT_%{postgresql_major})
The %defattr should not be needed nowadays.
Pavel
Created attachment 969469 [details]
possible fixes
Per fedora-review script (unless you plan to build against EPEL5):
===== MUST items =====
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/pgsql,
/usr/share/pgsql, /usr/share/pgsql/extension
praiskup: we need to require postgresql-server (and ideally
MODULE_COMPAT)
[!]: %build honors applicable compiler flags or justifies otherwise.
praiskup: CFLAGS are inherited from postgresql-devel currently
[x]: Package is named according to the Package Naming Guidelines.
praiskup: however, I would prefer pg-semver (semver is different project)
[!]: Rpmlint is run on all rpms the build produces.
praiskup: postgresql-libs requirement is redundant
[!]: Package requires other packages for directories it uses.
praiskup: we need to require postgresql-server
===== SHOULD items =====
Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
Thank you, fixed! Spec URL: https://rmarko.fedorapeople.org/packages/pg-semver.spec SRPM URL: https://rmarko.fedorapeople.org/packages/pg-semver-0.5.0-2.fc21.src.rpm Changes: https://rmarko.fedorapeople.org/packages/pg-semver.spec.diff Ack, and thanks! New Package SCM Request ======================= Package Name: pg-semver Short Description: A semantic version data type for PostgreSQL Upstream URL: https://github.com/theory/pg-semver Owners: rmarko Branches: f20 f21 el6 epel7 Git done (by process-git-requests). pg-semver-0.5.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/pg-semver-0.5.0-2.fc20 pg-semver-0.5.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/pg-semver-0.5.0-2.fc21 pg-semver-0.5.0-2.fc21 has been pushed to the Fedora 21 testing repository. Richard, we should probably push the packages into stable, according to
Package Review Process (or close this NEXTRELEASE). Also, have you considered
cnucnu (point 14)?
14. If possible, add your package to Upstream Release Monitoring.
15. You should make sure the review ticket is closed. You are welcome to close
it once the package has been built on the requested branches, or if you
built for one of the Fedora release branches you can ask Bodhi to close
the ticket for you when it completes the process. If you close the ticket
yourself, use NEXTRELEASE as the resolution.
Thanks for the reminder. Builds pushed to stable and added to monitoring. pg-semver-0.5.0-2.fc21 has been pushed to the Fedora 21 stable repository. pg-semver-0.5.0-2.fc20 has been pushed to the Fedora 20 stable repository. |