Bug 1174783

Summary:	[readdir-ahead]: indicate EOF for readdirp
Product:	[Community] GlusterFS	Reporter:	Raghavendra Bhat <rabhat>
Component:	unclassified	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1175753 (view as bug list)		Environment:
Last Closed:	2015-05-14 17:28:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1175753

Description Raghavendra Bhat 2014-12-16 13:29:36 UTC

Description of problem:

posix indicates EOF in readdir call by setting errno to ENOENT. But readdir-ahead is not doing it and is sending errno as 0. This causes problems when readdir-ahead is enabled along with USS and is accessed by windows.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-12-16 13:32:40 UTC

REVIEW: http://review.gluster.org/9283 (performance/readdir-ahead: indicate EOF for readdirp) posted (#1) for review on master by Raghavendra Bhat (raghavendra)

Comment 2 Anand Avati 2014-12-17 15:05:25 UTC

REVIEW: http://review.gluster.org/9283 (performance/readdir-ahead: indicate EOF for readdirp) posted (#2) for review on master by Raghavendra Bhat (raghavendra)

Comment 3 Anand Avati 2014-12-17 16:20:34 UTC

REVIEW: http://review.gluster.org/9283 (performance/readdir-ahead: indicate EOF for readdirp) posted (#3) for review on master by Raghavendra Bhat (raghavendra)

Comment 4 Anand Avati 2014-12-18 02:50:20 UTC

COMMIT: http://review.gluster.org/9283 committed in master by Vijay Bellur (vbellur) 
------
commit cca09a2a342980f427b590f2655d23c371386a02
Author: Raghavendra Bhat <raghavendra>
Date:   Tue Dec 16 19:01:20 2014 +0530

    performance/readdir-ahead: indicate EOF for readdirp
    
    posix xlator sends op_errno as ENOENT and op_ret as 0, to indicate readdir has
    been completed. readdir-ahead should send that op_errno that it has saved in the
    fd context, when it serves the readdir requests. Otherwise some xlators sitting
    above performance xlators such as snapview-client, which checks for end of
    readdir operation by checking op_ret to 0 and op_errno to ENOENT will not be
    able to identify end of readdir.
    
    Change-Id: Ib0835136c61cb1e0d7df933226c479c7db703a71
    BUG: 1174783
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/9283
    Reviewed-by: Raghavendra G <rgowdapp>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Brian Foster <bfoster>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 5 Niels de Vos 2015-05-14 17:28:43 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:35:46 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:38:08 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:45:14 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user