Bug 1175730

Summary:	[USS]: creating file/directories under .snaps shows wrong error message
Product:	[Community] GlusterFS	Reporter:	Vijaikumar Mallikarjuna <vmallika>
Component:	snapshot	Assignee:	Vijaikumar Mallikarjuna <vmallika>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.6.1	CC:	bugs, gluster-bugs, lmohanty, rabhat, rhinduja, smohan, storage-qa-internal, vmallika
Target Milestone:	---	Keywords:	Patch, Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.6.2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1159840	Environment:
Last Closed:	2015-02-11 09:11:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1158898, 1159840
Bug Blocks:	1163723

Description Vijaikumar Mallikarjuna 2014-12-18 13:45:13 UTC

+++ This bug was initially created as a clone of Bug #1159840 +++

When an attempt is made to create file/directories inside .snaps, it fails with wrong error message as "Stale file handle".

--- Additional comment from Anand Avati on 2014-11-04 03:10:13 EST ---

REVIEW: http://review.gluster.org/9039 (uss/gluster: creating file/directories inside .snaps should fail with EROFS) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Anand Avati on 2014-11-04 03:38:15 EST ---

REVIEW: http://review.gluster.org/9039 (uss/gluster: creating file/directories inside .snaps should fail with EROFS) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Anand Avati on 2014-11-13 04:51:57 EST ---

REVIEW: http://review.gluster.org/9039 (uss/gluster: creating file/directories inside .snaps should fail with EROFS) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Anand Avati on 2014-11-13 09:55:16 EST ---

COMMIT: http://review.gluster.org/9039 committed in master by Vijay Bellur (vbellur) 
------
commit b4597a92ccfebf362c63977bc4bada7b65e28753
Author: vmallika <vmallika>
Date:   Thu Nov 13 15:13:39 2014 +0530

    uss/gluster: creating file/directories inside .snaps should fail with
    EROFS
    
    When an attempt is made to create file/directories inside .snaps, it
    fails with wrong error message as "Stale file handle". It should fail
    with "Read-only file system"
    
    Change-Id: I3a812a0afc4762cbb71ab180b9394c866e576a66
    BUG: 1159840
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/9039
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 1 Anand Avati 2014-12-18 15:06:47 UTC

REVIEW: http://review.gluster.org/9300 (uss/gluster: creating file/directories inside .snaps should fail with EROFS) posted (#1) for review on release-3.6 by Sachin Pandit (spandit)

Comment 2 Anand Avati 2014-12-18 17:20:54 UTC

REVIEW: http://review.gluster.org/9300 (uss/gluster: creating file/directories inside .snaps should fail with EROFS.) posted (#2) for review on release-3.6 by Sachin Pandit (spandit)

Comment 3 Anand Avati 2014-12-19 07:19:58 UTC

REVIEW: http://review.gluster.org/9300 (uss/gluster: creating file/directories inside .snaps should fail with EROFS) posted (#3) for review on release-3.6 by Sachin Pandit (spandit)

Comment 4 Anand Avati 2014-12-19 09:00:10 UTC

REVIEW: http://review.gluster.org/9300 (uss/gluster: creating file/directories inside .snaps should fail with EROFS.) posted (#4) for review on release-3.6 by Sachin Pandit (spandit)

Comment 5 Anand Avati 2014-12-22 12:19:09 UTC

COMMIT: http://review.gluster.org/9300 committed in release-3.6 by Raghavendra Bhat (raghavendra) 
------
commit fc67bb6e45da96aee381ca804d79c94d4e3a59a6
Author: vmallika <vmallika>
Date:   Thu Nov 13 15:13:39 2014 +0530

    uss/gluster: creating file/directories inside .snaps should fail with EROFS.
    
    When an attempt is made to create file/directories inside .snaps, it
    fails with wrong error message as "Stale file handle". It should fail
    with "Read-only file system"
    
    Change-Id: I3a812a0afc4762cbb71ab180b9394c866e576a66
    BUG: 1175730
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/9039
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/9300
    Reviewed-by: Raghavendra Bhat <raghavendra>

Comment 6 Raghavendra Bhat 2015-02-11 09:11:35 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.2, please reopen this bug report.

glusterfs-3.6.2 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should already be or become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

The fix for this bug likely to be included in all future GlusterFS releases i.e. release > 3.6.2.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/5978
[2] http://news.gmane.org/gmane.comp.file-systems.gluster.user
[3] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137