Bug 1175952

> To strike the balance, this efl package makes subpackages for each of these
> libraries, 

What balance? What is the rationale? It looks like a strange decision, because of the inter-dependencies between these libs. For example:

  $ rpm -qpR evas-1.12.2-1.fc22.x86_64.rpm |grep ^libe
  libeet.so.1()(64bit)
  libefl.so.1()(64bit)
  libeina.so.1()(64bit)
  libeo.so.1()(64bit)
  libevas.so.1()(64bit)

  $ rpm -qpR edje-1.12.2-1.fc22.x86_64.rpm |grep ^libe 
  libecore.so.1()(64bit)
  libecore_audio.so.1()(64bit)
  libecore_con.so.1()(64bit)
  libecore_evas.so.1()(64bit)
  libecore_file.so.1()(64bit)
  libecore_imf.so.1()(64bit)
  libecore_imf_evas.so.1()(64bit)
  libecore_input.so.1()(64bit)
  libecore_input_evas.so.1()(64bit)
  libedje.so.1()(64bit)
  libeet.so.1()(64bit)
  libeeze.so.1()(64bit)
  libefl.so.1()(64bit)
  libeina.so.1()(64bit)
  libeio.so.1()(64bit)
  libembryo.so.1()(64bit)
  libemotion.so.1()(64bit)
  libeo.so.1()(64bit)
  libephysics.so.1()(64bit)
  libevas.so.1()(64bit)

With such heavy inter-deps it makes no sense to create subpackages. Especially the dep on libelf.so.1 will always pull in the full show via your "elf" base package and its explicit Requires.

Bug 1164257 - Review Request: efl - Enlightenment Fundament Library

Team-work time, guys!

*** Bug 1164257 has been marked as a duplicate of this bug. ***

Ping, this is getting too long.

I'm sorry. I'm just now having cycles to work on things again. I'll take the time to rework my package to kill off the subpackage model.

Updated spec: https://spot.fedorapeople.org/efl.spec
Updated SRPM: https://spot.fedorapeople.org/efl-1.13.1-2.fc21.src.rpm
Koji Rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9139662

This updates to 1.13.1, drops the subpackages, fixes the FSF address issues from rpmlint, fixes compilation of drm support.

e_dbus doesn't exist anymore. It has been replaced by eldbus.
Your package should obsoletes it.

I was on the fence about doing that originally, but it makes sense.

Updated spec: https://spot.fedorapeople.org/efl.spec
Updated SRPM: https://spot.fedorapeople.org/efl-1.13.1-3.fc21.src.rpm

Adds e_dbus/e_dbus-devel Provides/Obsoletes.

Will it enable the wayland support? 
AFAIK, if we enable wayland support here, it clashed with mese-libEGL-devel when building enlightment-0.19

$ grep cmake efl.spec
%{_libdir}/cmake/Efl/
%{_libdir}/cmake/Ecore*/*.cmake
%{_libdir}/cmake/Edje/
%{_libdir}/cmake/Eet/*.cmake
%{_libdir}/cmake/EetCxx/*.cmake
%{_libdir}/cmake/Eeze/
%{_libdir}/cmake/Efreet/
%{_libdir}/cmake/Eina*/*.cmake
%{_libdir}/cmake/Eldbus/
%{_libdir}/cmake/Elua/
%{_libdir}/cmake/Emotion/
%{_libdir}/cmake/Eo/
%{_libdir}/cmake/EoCxx/
%{_libdir}/cmake/Eolian/
%{_libdir}/cmake/EolianCxx/
%{_libdir}/cmake/Ethumb/
%{_libdir}/cmake/EthumbClient/
%{_libdir}/cmake/Evas/*.cmake
%{_libdir}/cmake/EvasCxx/*.cmake

Is there a special reason why parts of the spec file include only *.cmake whereas other parts include the parent directory? The first bears a high risk of creating unowned directories.

That is exactly what I'm seeing in the output from fedora-review:

[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib64/cmake/EcoreCxx, /usr/lib64/cmake/Eet,
     /usr/lib64/cmake/Ecore, /usr/lib64/cmake/Evas, /usr/lib64/cmake/EinaCxx,
     /usr/lib64/cmake/EvasCxx, /usr/lib64/cmake/Eina, /usr/lib64/cmake/EetCxx
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/cmake/EcoreCxx,
     /usr/lib64/cmake/Evas, /usr/share/dbus-1, /usr/lib64/cmake/EvasCxx,
     /usr/lib64/cmake/Eet, /usr/share/dbus-1/services, /usr/lib64/cmake/Eina,
     /usr/lib64/cmake/EetCxx, /usr/lib64/cmake/EinaCxx, /usr/lib64/cmake/Ecore
[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/ethumb(ethumb),
     /usr/share/edje(edje-devel), /usr/lib64/ecore(ecore),
     /usr/lib64/evas/modules/engines(evas),
     /usr/lib64/evas/modules/engines/wayland_shm(evas), /usr/include/ethumb-1
     (ethumb-devel), /usr/lib64/efreet(efreet), /usr/include/eet-1(eet-devel),
     /usr/lib64/evas/modules/engines/fb(evas), /usr/share/evas(evas),
     /usr/lib64/evas/cserve2(evas), /usr/include/eio-1(eio-devel),
     /usr/include/ecore-1(ecore-devel), /usr/share/edje/include(edje-devel),
     /usr/include/eeze-1(eeze-devel), /usr/lib64/ethumb(ethumb),
     /usr/include/eina-1/eina(libeina-devel), /usr/lib64/emotion(emotion),
     /usr/include/eina-1(libeina-devel),
     /usr/lib64/evas/modules/engines/software_x11(evas), /usr/include/edje-1
     (edje-devel), /usr/include/efreet-1(efreet-devel), /usr/include/evas-1
     (evas-devel), /usr/lib64/edje(edje, emotion),
     /usr/lib64/evas/modules(evas),
     /usr/lib64/evas/modules/engines/gl_x11(evas), /usr/lib64/evas(evas),
     /usr/include/emotion-1(emotion-devel), /usr/share/emotion(emotion),
     /usr/lib64/edje/modules(emotion),
     /usr/lib64/edje/modules/emotion(emotion), /usr/lib64/edje/utils(edje)

Whoops. Fixed the cmake issues:

New SPEC: https://spot.fedorapeople.org/efl.spec
New SRPM: https://spot.fedorapeople.org/efl-1.13.1-5.fc21.src.rpm

Ok, there's a problem with the cmake package in rawhide right now so I'm re-running fedora-review with f22 instead. While it's running I have some feedback:

Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

This is due to the cmake problem in rawhide, ignore for now.


- Permissions on files are set properly.
  Note: See rpmlint output
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions


- Package contains BR: python2-devel or python3-devel

This package does not BR python at all. I haven't looked through the packaged files but I have to assume that it's finding some python files?


- If (and only if) the source package includes the text of the license(s) in
  its own file, then that file, containing the text of the license(s) for the
  package is included in %doc.
  Note: Cannot find COPYING.BSD in rpm(s)
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


Generic:
[!]: update-mime-database is invoked in %post and %postun if package stores
     mime configuration in /usr/share/mime/packages.
     Note: mimeinfo files in: efl
     See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo


[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/ethumb(ethumb),
     /usr/share/edje(edje-devel), /usr/lib64/ecore(ecore),
     /usr/lib64/evas/modules/engines(evas), /usr/lib64/efreet(efreet),
     /usr/include/ethumb-1(ethumb-devel),
     /usr/lib64/evas/modules/engines/wayland_shm(evas), /usr/include/eet-1
     (eet-devel), /usr/lib64/evas/modules/engines/fb(evas),
     /usr/share/evas(evas), /usr/lib64/evas/cserve2(evas), /usr/include/eio-1
     (eio-devel), /usr/include/ecore-1(ecore-devel), /usr/include/edje-1(edje-
     devel), /usr/include/eeze-1(eeze-devel), /usr/lib64/ethumb(ethumb),
     /usr/include/eina-1/eina(libeina-devel), /usr/lib64/emotion(emotion),
     /usr/include/eina-1(libeina-devel),
     /usr/lib64/evas/modules/engines/software_x11(evas),
     /usr/share/edje/include(edje-devel), /usr/include/efreet-1(efreet-devel),
     /usr/include/evas-1(evas-devel), /usr/lib64/edje(edje, emotion),
     /usr/lib64/evas/modules(evas), /usr/lib64/evas(evas),
     /usr/lib64/evas/modules/engines/gl_x11(evas), /usr/include/emotion-1
     (emotion-devel), /usr/share/emotion(emotion),
     /usr/lib64/edje/modules(emotion),
     /usr/lib64/edje/modules/emotion(emotion), /usr/lib64/edje/utils(edje)

Is this somehow causes by getting rid of all the sub-packages?


Rpmlint
-------
Checking: efl-1.13.1-5.fc23.x86_64.rpm
          efl-devel-1.13.1-5.fc23.x86_64.rpm
          efl-1.13.1-5.fc23.src.rpm
efl.x86_64: W: shared-lib-calls-exit /usr/lib64/libecore_x.so.1.13.1 exit.5
efl.x86_64: E: setuid-binary /usr/bin/eeze_scanner root 04555L

I'm assuming eeze needs setuid?


efl.x86_64: E: non-standard-executable-perm /usr/bin/eeze_scanner 04555L
efl.x86_64: E: non-standard-executable-perm /usr/bin/eeze_scanner 04555L

Needed?

efl-devel.x86_64: E: library-without-ldconfig-postin /usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.py
efl-devel.x86_64: E: library-without-ldconfig-postun /usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.py
efl-devel.x86_64: E: library-without-ldconfig-postin /usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.pyc
efl-devel.x86_64: E: library-without-ldconfig-postun /usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.pyc
efl-devel.x86_64: E: library-without-ldconfig-postin /usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.pyo
efl-devel.x86_64: E: library-without-ldconfig-postun /usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.pyo

I'm assuming this is what's causing the python errors.

One more thing (for now!)

%{!?_licensedir:%global license %%doc}
%license licenses/COPYING.BSD licenses/COPYING.GPL licenses/COPYING.LGPL licenses/COPYING.SMALL
%doc AUTHORS COPYING COMPLIANCE NEWS README

The plain COPYING file in the root of the source should be moved to the %license line.

Yes, the setuid perms are intentional and intended. The weird python files are gdb helpers, we do not need BR: python here, nor do we need ldconfig on them. COPYING.BSD is in the rpm:

- Added the missing mimeinfo scriptlets.
- Moved COPYING to %license
- Fixed provides and obsoletes (efl obsoletes a lot of packages in Fedora).

New SRPM: https://spot.fedorapeople.org/efl-1.13.1-6.fc22.src.rpm
New SPEC: https://spot.fedorapeople.org/efl.spec

Ok, I'm pretty much done with the review. Last couple of questions:

1. Package must own all directories that it creates.
   Note: Directories without known owners: /usr/share/dbus-1,
   /usr/share/dbus-1/services

2. There are 523 occurances of unused-direct-shlib-dependency on the installed package so I won't paste it all here, but is there a easy way to fix?

1) efl definitely shouldn't own /usr/share/dbus-1 or /usr/share/dbus-1/services. :)

2) I'm not sure how to see those errors, in order to fix them. Maybe attach it here as a txt file and i'll look?

Created attachment 1009195 [details]
rpmlint output of installed packages

Meant to do this earlier but was distracted by $DAYJOB.

(In reply to Tom "spot" Callaway from comment #17)
> 1) efl definitely shouldn't own /usr/share/dbus-1 or
> /usr/share/dbus-1/services. :)

I think this could be silenced by "Requires: dbus" but like "hicolor-icon-theme" for packages that install icons to /usr/share/icons/hicolor, I'm not sure it SHOULD be required

Looking at the guidelines it would appear elf should one those directories WITH dbus (multi-owner):

http://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

Yeaaah. I'm not going to untangle efl for that. If someone wants to do it, I'd consider helping push that patch upstream.

I did fix the dbus dir ownership in -7.

New SRPM: https://spot.fedorapeople.org/efl-1.13.1-7.fc22.src.rpm
New SPEC: https://spot.fedorapeople.org/efl.spec

(In reply to Tom "spot" Callaway from comment #20)
> Yeaaah. I'm not going to untangle efl for that. If someone wants to do it,
> I'd consider helping push that patch upstream.

Sounds good to me, but sometimes it's as easy as adding -Wl,--as-needed to the linker commands via C/CXXFLAGS.

Not a blocker though.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD like) LGPL
     (v2.1 or later)", "MIT/X11 (BSD like)", "zlib/libpng", "ISC", "GPL (v2 or
     later) (with incorrect FSF address)", "BSD (2 clause)", "LGPL (v2.1 or
     later)", "*No copyright* Public domain", "*No copyright* LGPL (v2.1 or
     later)". 1637 files have unknown license. Detailed output of licensecheck
     in /home/build/fedora-review/1175952-efl/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[-]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Package uses hardened build flags if required to.
     Note: suid files: eeze_scanner
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.

===== SHOULD items =====

Generic:
[x]: update-mime-database is invoked in %post and %postun if package stores
     mime configuration in /usr/share/mime/packages.
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[-]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[-]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Package should not use obsolete m4 macros
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: efl-1.13.1-6.fc23.x86_64.rpm
          efl-devel-1.13.1-6.fc23.x86_64.rpm
          efl-1.13.1-6.fc23.src.rpm
efl.x86_64: W: shared-lib-calls-exit /usr/lib64/libecore_x.so.1.13.1 exit.5
efl.x86_64: E: setuid-binary /usr/bin/eeze_scanner root 04555L
efl.x86_64: E: non-standard-executable-perm /usr/bin/eeze_scanner 04555L
efl.x86_64: E: non-standard-executable-perm /usr/bin/eeze_scanner 04555L
efl.x86_64: W: no-manual-page-for-binary eolian_gen
efl.x86_64: W: no-manual-page-for-binary eolian_cxx
efl.x86_64: W: no-manual-page-for-binary vieet
efl.x86_64: W: no-manual-page-for-binary ecore_evas_convert
efl.x86_64: W: no-manual-page-for-binary evas_cserve2_client
efl.x86_64: W: no-manual-page-for-binary eeze_disk_ls
efl.x86_64: W: no-manual-page-for-binary edje_codegen
efl.x86_64: W: no-manual-page-for-binary embryo_cc
efl.x86_64: W: no-manual-page-for-binary edje_recc
efl.x86_64: W: no-manual-page-for-binary diffeet
efl.x86_64: W: no-manual-page-for-binary eeze_umount
efl.x86_64: W: no-manual-page-for-binary ethumbd_client
efl.x86_64: W: no-manual-page-for-binary evas_cserve2_debug
efl.x86_64: W: no-manual-page-for-binary edje_watch
efl.x86_64: W: no-manual-page-for-binary evas_cserve2_usage
efl.x86_64: W: no-manual-page-for-binary edje_pick
efl.x86_64: W: no-manual-page-for-binary ethumb
efl.x86_64: W: no-manual-page-for-binary evas_cserve2_shm_debug
efl.x86_64: W: no-manual-page-for-binary eldbus-codegen
efl.x86_64: W: no-manual-page-for-binary elua
efl.x86_64: W: no-manual-page-for-binary eeze_scanner
efl.x86_64: W: no-manual-page-for-binary edje_player
efl.x86_64: W: no-manual-page-for-binary edje_external_inspector
efl.x86_64: W: no-manual-page-for-binary eeze_mount
efl.x86_64: W: no-manual-page-for-binary edje_cc
efl.x86_64: W: no-manual-page-for-binary edje_inspector
efl.x86_64: W: no-manual-page-for-binary edje_decc
efl.x86_64: W: no-manual-page-for-binary ethumbd
efl.x86_64: W: no-manual-page-for-binary eet
efl.x86_64: W: no-manual-page-for-binary efreetd
efl-devel.x86_64: W: only-non-binary-in-usr-lib
efl-devel.x86_64: W: no-documentation
efl-devel.x86_64: E: library-without-ldconfig-postin /usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.py
efl-devel.x86_64: E: library-without-ldconfig-postun /usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.py
efl-devel.x86_64: E: library-without-ldconfig-postin /usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.pyc
efl-devel.x86_64: E: library-without-ldconfig-postun /usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.pyc
efl-devel.x86_64: E: library-without-ldconfig-postin /usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.pyo
efl-devel.x86_64: E: library-without-ldconfig-postun /usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.pyo
efl-devel.x86_64: W: no-manual-page-for-binary eina-bench-cmp
3 packages and 0 specfiles checked; 9 errors, 34 warnings.


Rpmlint (installed packages)
----------------------------
There are 523 occurances of unused-direct-shlib-dependency so I won't paste it all here.
Attached to BZ ticket.


Requires
--------
efl-devel (rpmlib, GLIBC filtered):
    /usr/bin/env
    /usr/bin/pkg-config
    efl(x86-64)
    libX11-devel
    pkgconfig
    pkgconfig(bullet)
    pkgconfig(dbus-1)
    pkgconfig(ecore)
    pkgconfig(ecore-audio)
    pkgconfig(ecore-con)
    pkgconfig(ecore-drm)
    pkgconfig(ecore-evas)
    pkgconfig(ecore-file)
    pkgconfig(ecore-imf)
    pkgconfig(ecore-imf-evas)
    pkgconfig(ecore-input)
    pkgconfig(ecore-input-evas)
    pkgconfig(edje)
    pkgconfig(eet)
    pkgconfig(eeze)
    pkgconfig(efl)
    pkgconfig(eina)
    pkgconfig(eio)
    pkgconfig(eldbus)
    pkgconfig(embryo)
    pkgconfig(eo)
    pkgconfig(ephysics)
    pkgconfig(ethumb)
    pkgconfig(evas)
    pkgconfig(fontconfig)
    pkgconfig(freetype2)
    pkgconfig(fribidi)
    pkgconfig(gbm)
    pkgconfig(glib-2.0)
    pkgconfig(gthread-2.0)
    pkgconfig(harfbuzz)
    pkgconfig(libdrm)
    pkgconfig(libinput)
    pkgconfig(libpng)
    pkgconfig(libpulse)
    pkgconfig(libsystemd-daemon)
    pkgconfig(libsystemd-journal)
    pkgconfig(libudev)
    pkgconfig(luajit)
    pkgconfig(mount)
    pkgconfig(openssl)
    pkgconfig(sdl2)
    pkgconfig(sndfile)
    pkgconfig(tslib-0.0)
    pkgconfig(wayland-client)
    pkgconfig(wayland-cursor)
    pkgconfig(xkbcommon)
    pkgconfig(zlib)
    systemd

efl (rpmlib, GLIBC filtered):
    /bin/sh
    libBulletCollision.so.2.82()(64bit)
    libBulletDynamics.so.2.82()(64bit)
    libBulletSoftBody.so.2.82()(64bit)
    libGL.so.1()(64bit)
    libLinearMath.so.2.82()(64bit)
    libSDL2-2.0.so.0()(64bit)
    libX11.so.6()(64bit)
    libXcomposite.so.1()(64bit)
    libXcursor.so.1()(64bit)
    libXdamage.so.1()(64bit)
    libXext.so.6()(64bit)
    libXfixes.so.3()(64bit)
    libXi.so.6()(64bit)
    libXinerama.so.1()(64bit)
    libXp.so.6()(64bit)
    libXrandr.so.2()(64bit)
    libXrender.so.1()(64bit)
    libXss.so.1()(64bit)
    libXtst.so.6()(64bit)
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libcrypto.so.10(libcrypto.so.10)(64bit)
    libdbus-1.so.3()(64bit)
    libdl.so.2()(64bit)
    libdrm.so.2()(64bit)
    libecore.so.1()(64bit)
    libecore_audio.so.1()(64bit)
    libecore_con.so.1()(64bit)
    libecore_drm.so.1()(64bit)
    libecore_evas.so.1()(64bit)
    libecore_fb.so.1()(64bit)
    libecore_file.so.1()(64bit)
    libecore_imf.so.1()(64bit)
    libecore_imf_evas.so.1()(64bit)
    libecore_input.so.1()(64bit)
    libecore_input_evas.so.1()(64bit)
    libecore_ipc.so.1()(64bit)
    libecore_sdl.so.1()(64bit)
    libecore_wayland.so.1()(64bit)
    libecore_x.so.1()(64bit)
    libedje.so.1()(64bit)
    libeet.so.1()(64bit)
    libeeze.so.1()(64bit)
    libefl.so.1()(64bit)
    libefreet.so.1()(64bit)
    libeina.so.1()(64bit)
    libeio.so.1()(64bit)
    libeldbus.so.1()(64bit)
    libelua.so.1()(64bit)
    libembryo.so.1()(64bit)
    libemotion.so.1()(64bit)
    libeo.so.1()(64bit)
    libeolian.so.1()(64bit)
    libephysics.so.1()(64bit)
    libethumb.so.1()(64bit)
    libethumb_client.so.1()(64bit)
    libevas.so.1()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libfribidi.so.0()(64bit)
    libgbm.so.1()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgif.so.4()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgstaudio-1.0.so.0()(64bit)
    libgstbase-1.0.so.0()(64bit)
    libgstreamer-1.0.so.0()(64bit)
    libgsttag-1.0.so.0()(64bit)
    libgstvideo-1.0.so.0()(64bit)
    libgthread-2.0.so.0()(64bit)
    libharfbuzz.so.0()(64bit)
    libinput.so.10()(64bit)
    libinput.so.10(LIBINPUT_0.12.0)(64bit)
    libjpeg.so.62()(64bit)
    libjpeg.so.62(LIBJPEG_6.2)(64bit)
    libluajit-5.1.so.2()(64bit)
    libm.so.6()(64bit)
    libmount.so.1()(64bit)
    libmount.so.1(MOUNT_2.19)(64bit)
    libmount.so.1(MOUNT_2.20)(64bit)
    libopenjpeg.so.1()(64bit)
    libpng16.so.16()(64bit)
    libpng16.so.16(PNG16_0)(64bit)
    libpthread.so.0()(64bit)
    libpulse.so.0()(64bit)
    libpulse.so.0(PULSE_0)(64bit)
    librt.so.1()(64bit)
    libscim-1.0.so.8()(64bit)
    libscim-1.0.so.8(LIBSCIM_1.0)(64bit)
    libsndfile.so.1()(64bit)
    libsndfile.so.1(libsndfile.so.1.0)(64bit)
    libssl.so.10()(64bit)
    libssl.so.10(libssl.so.10)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libsystemd.so.0()(64bit)
    libsystemd.so.0(LIBSYSTEMD_209)(64bit)
    libtiff.so.5()(64bit)
    libtiff.so.5(LIBTIFF_4.0)(64bit)
    libts-0.0.so.0()(64bit)
    libudev.so.1()(64bit)
    libudev.so.1(LIBUDEV_183)(64bit)
    libudev.so.1(LIBUDEV_199)(64bit)
    libwayland-client.so.0()(64bit)
    libwayland-cursor.so.0()(64bit)
    libwebp.so.5()(64bit)
    libxkbcommon.so.0()(64bit)
    libxkbcommon.so.0(V_0.5.0)(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)



Provides
--------
efl-devel:
    e_dbus-devel
    e_dbus-devel(x86-64)
    ecore-devel(x86-64)
    edje-devel(x86-64)
    eet-devel(x86-64)
    eeze-devel(x86-64)
    efl-devel
    efl-devel(x86-64)
    efreet-devel(x86-64)
    eina-devel(x86-64)
    eio-devel(x86-64)
    eldbus-devel(x86-64)
    elocation-devel(x86-64)
    embryo-devel(x86-64)
    emotion-devel(x86-64)
    eo-devel(x86-64)
    eolian-devel(x86-64)
    ephysics-devel(x86-64)
    ethumb-devel(x86-64)
    evas-devel(x86-64)
    libeina-devel
    libeina-devel(x86-64)
    pkgconfig(ecore)
    pkgconfig(ecore-audio)
    pkgconfig(ecore-audio-cxx)
    pkgconfig(ecore-avahi)
    pkgconfig(ecore-con)
    pkgconfig(ecore-cxx)
    pkgconfig(ecore-drm)
    pkgconfig(ecore-evas)
    pkgconfig(ecore-fb)
    pkgconfig(ecore-file)
    pkgconfig(ecore-imf)
    pkgconfig(ecore-imf-evas)
    pkgconfig(ecore-input)
    pkgconfig(ecore-input-evas)
    pkgconfig(ecore-ipc)
    pkgconfig(ecore-sdl)
    pkgconfig(ecore-wayland)
    pkgconfig(ecore-x)
    pkgconfig(edje)
    pkgconfig(edje-cxx)
    pkgconfig(eet)
    pkgconfig(eet-cxx)
    pkgconfig(eeze)
    pkgconfig(efl)
    pkgconfig(efl-cxx)
    pkgconfig(efreet)
    pkgconfig(efreet-mime)
    pkgconfig(efreet-trash)
    pkgconfig(eina)
    pkgconfig(eina-cxx)
    pkgconfig(eio)
    pkgconfig(eldbus)
    pkgconfig(elocation)
    pkgconfig(elua)
    pkgconfig(embryo)
    pkgconfig(emotion)
    pkgconfig(eo)
    pkgconfig(eo-cxx)
    pkgconfig(eolian)
    pkgconfig(eolian-cxx)
    pkgconfig(ephysics)
    pkgconfig(ethumb)
    pkgconfig(ethumb_client)
    pkgconfig(evas)
    pkgconfig(evas-cxx)
    pkgconfig(evas-drm)
    pkgconfig(evas-fb)
    pkgconfig(evas-opengl-sdl)
    pkgconfig(evas-opengl-x11)
    pkgconfig(evas-software-buffer)
    pkgconfig(evas-software-x11)
    pkgconfig(evas-wayland-shm)

efl:
    e_dbus
    e_dbus(x86-64)
    ecore(x86-64)
    edje(x86-64)
    eet(x86-64)
    eeze(x86-64)
    efl
    efl(x86-64)
    efreet(x86-64)
    eina(x86-64)
    eio(x86-64)
    eldbus(x86-64)
    elocation(x86-64)
    elua(x86-64)
    embryo(x86-64)
    emotion(x86-64)
    eo(x86-64)
    eolian(x86-64)
    ephysics(x86-64)
    ethumb(x86-64)
    evas(x86-64)
    libecore.so.1()(64bit)
    libecore_audio.so.1()(64bit)
    libecore_avahi.so.1()(64bit)
    libecore_con.so.1()(64bit)
    libecore_drm.so.1()(64bit)
    libecore_evas.so.1()(64bit)
    libecore_fb.so.1()(64bit)
    libecore_file.so.1()(64bit)
    libecore_imf.so.1()(64bit)
    libecore_imf_evas.so.1()(64bit)
    libecore_input.so.1()(64bit)
    libecore_input_evas.so.1()(64bit)
    libecore_ipc.so.1()(64bit)
    libecore_sdl.so.1()(64bit)
    libecore_wayland.so.1()(64bit)
    libecore_x.so.1()(64bit)
    libedje.so.1()(64bit)
    libeet.so.1()(64bit)
    libeeze.so.1()(64bit)
    libefl.so.1()(64bit)
    libefreet.so.1()(64bit)
    libefreet_mime.so.1()(64bit)
    libefreet_trash.so.1()(64bit)
    libeina
    libeina(x86-64)
    libeina.so.1()(64bit)
    libeio.so.1()(64bit)
    libeldbus.so.1()(64bit)
    libelocation.so.1()(64bit)
    libelua.so.1()(64bit)
    libembryo.so.1()(64bit)
    libemotion.so.1()(64bit)
    libeo.so.1()(64bit)
    libeolian.so.1()(64bit)
    libephysics.so.1()(64bit)
    libethumb.so.1()(64bit)
    libethumb_client.so.1()(64bit)
    libevas.so.1()(64bit)



Unversioned so-files
--------------------
efl: /usr/lib64/ecore/system/systemd/v-1.13/module.so
efl: /usr/lib64/ecore/system/upower/v-1.13/module.so
efl: /usr/lib64/ecore_evas/engines/drm/v-1.13/module.so
efl: /usr/lib64/ecore_evas/engines/extn/v-1.13/module.so
efl: /usr/lib64/ecore_evas/engines/fb/v-1.13/module.so
efl: /usr/lib64/ecore_evas/engines/sdl/v-1.13/module.so
efl: /usr/lib64/ecore_evas/engines/wayland/v-1.13/module.so
efl: /usr/lib64/ecore_evas/engines/x/v-1.13/module.so
efl: /usr/lib64/ecore_imf/modules/scim/v-1.13/module.so
efl: /usr/lib64/ecore_imf/modules/wayland/v-1.13/module.so
efl: /usr/lib64/ecore_imf/modules/xim/v-1.13/module.so
efl: /usr/lib64/edje/modules/emotion/v-1.13/module.so
efl: /usr/lib64/eeze/modules/sensor/fake/v-1.13/module.so
efl: /usr/lib64/eeze/modules/sensor/udev/v-1.13/module.so
efl: /usr/lib64/emotion/modules/gstreamer1/v-1.13/module.so
efl: /usr/lib64/ethumb/modules/emotion/v-1.13/module.so
efl: /usr/lib64/evas/modules/engines/drm/v-1.13/module.so
efl: /usr/lib64/evas/modules/engines/fb/v-1.13/module.so
efl: /usr/lib64/evas/modules/engines/gl_generic/v-1.13/module.so
efl: /usr/lib64/evas/modules/engines/gl_sdl/v-1.13/module.so
efl: /usr/lib64/evas/modules/engines/gl_x11/v-1.13/module.so
efl: /usr/lib64/evas/modules/engines/software_x11/v-1.13/module.so
efl: /usr/lib64/evas/modules/engines/wayland_shm/v-1.13/module.so
efl: /usr/lib64/evas/modules/image_loaders/gif/v-1.13/module.so
efl: /usr/lib64/evas/modules/image_loaders/jp2k/v-1.13/module.so
efl: /usr/lib64/evas/modules/image_loaders/tiff/v-1.13/module.so
efl: /usr/lib64/evas/modules/image_loaders/webp/v-1.13/module.so
efl: /usr/lib64/evas/modules/image_savers/tiff/v-1.13/module.so
efl: /usr/lib64/evas/modules/image_savers/webp/v-1.13/module.so

Source checksums
----------------
http://download.enlightenment.org/rel/libs/efl/efl-1.13.1.tar.xz :
  CHECKSUM(SHA256) this package     : 7e06e11678063fd74522f8fc56eb3d0235e9d7f889639e2ecff4bb663a2568d6
  CHECKSUM(SHA256) upstream package : 7e06e11678063fd74522f8fc56eb3d0235e9d7f889639e2ecff4bb663a2568d6


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/bin/fedora-review -b 1175952 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

*** APPROVED ***

Thanks for the review, Richard. :)

New Package SCM Request
=======================
Package Name: efl
Short Description: Collection of Enlightenment libraries 
Upstream URL: http://enlightenment.org/
Owners: spot
Branches: f20 f21 f22 
InitialCC:

Git done (by process-git-requests).

efl-1.13.1-7.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/efl-1.13.1-7.fc22

efl-1.13.1-7.fc22 has been pushed to the Fedora 22 testing repository.

efl-1.13.1-7.fc22 has been pushed to the Fedora 22 stable repository.